Add error message for rsync not found in image#2250
Merged
Conversation
Michaelvll
reviewed
Jul 16, 2023
Collaborator
Michaelvll
left a comment
There was a problem hiding this comment.
Thanks for the improvement of the UX @cblmemo! Left two comments.
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
Michaelvll
approved these changes
Jul 20, 2023
Collaborator
Michaelvll
left a comment
There was a problem hiding this comment.
Thanks for adding this @cblmemo! LGTM.
juanmichelini
pushed a commit
to LCA-CI-builds-repair/skypilot
that referenced
this pull request
Jul 10, 2025
* fix * Update sky/backends/cloud_vm_ray_backend.py Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com> * style * rerun the test --------- Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially fixes #1603 by adding an error message that indicates rsync is not found in the specified image, so that users don't need to dive deep into SkyPilot code to figure out why.
#1641 and #1910 will add cloud-init support for GCP and Azure. After these two are merged, we could have a new PR to add the installation of rsync.
An example of the error message:
Tested (run the relevant ones):
bash format.shsky launch --cloud gcp --image-id <some image without rsync>pytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh