[Core] Fix user_hash mismatch issue#9252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the api_login flow to save the endpoint and clear residual service account tokens before the initial health check, ensuring the server correctly triggers SSO when required. It also synchronizes the local user hash with the final authenticated health check response. New unit tests have been added to verify these behaviors. Feedback was provided regarding unused variables in the newly added test cases that should be cleaned up.
aylei
approved these changes
Apr 7, 2026
Collaborator
aylei
left a comment
There was a problem hiding this comment.
LGTM, thanks @DanielZhangQD !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sky api loginskipping SSO when a residual service account token from a previous login is still in config, by clearing it before the first health check.~/.sky/user_hashnot being updated after SSO login, causing false "Cluster was created by another user" warnings on subsequentsky launch.Tested (run the relevant ones):
bash format.shsky api loginwith:/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)