Fix PrimeIntellect query_instances TypeError on retry_if_missing#9259
Merged
kyuds merged 3 commits intoApr 6, 2026
Merged
Conversation
The PrimeIntellect provider's query_instances() was missing the retry_if_missing parameter that the base interface expects, causing a TypeError when SkyPilot tried to query cluster status. Fixes skypilot-org#9256 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the query_instances function signature in the Prime Intellect provisioner by adding the retry_if_missing parameter. However, the function signature remains incomplete as it is missing the cluster_name parameter required by the base provisioner interface, and the internal status_map lacks the PROVISIONING status, which could lead to runtime errors.
…s mapping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Good catches — both fixed in the latest commit:
Both were pre-existing bugs that this PR now addresses alongside the original |
kyuds
reviewed
Apr 6, 2026
kyuds
approved these changes
Apr 6, 2026
Collaborator
kyuds
left a comment
kyuds
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query_instances()was missing theretry_if_missingkeyword argument that the base provisioner interface passes to all cloud providersTypeError: query_instances() got an unexpected keyword argument 'retry_if_missing'when querying cluster status after launchFix
Added the
retry_if_missing: bool = Falseparameter toquery_instances()insky/provision/primeintellect/instance.py, matching all other provider implementations.Test plan
delpattern is used to suppress lint warnings🤖 Generated with Claude Code