Prevent warnings in PHP 8.2 when $col_values is empty (wp-cli#160)

danielbachhuber · web-flow · commit 2d27f0db5c36 · 2023-07-21T04:37:15.000-07:00
diff --git a/lib/cli/table/Ascii.php b/lib/cli/table/Ascii.php
@@ -180,7 +180,7 @@ public function row( array $row ) {
 				$row_values = array();
 				$has_more = false;
 				foreach( $extra_rows as $col => &$col_values ) {
-					$row_values[ $col ] = array_shift( $col_values );
+					$row_values[ $col ] = ! empty( $col_values ) ? array_shift( $col_values ) : '';
 					if ( count( $col_values ) ) {
 						$has_more = true;
 					}

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ public function row( array $row ) {`
`180`	`180`	`$row_values = array();`
`181`	`181`	`$has_more = false;`
`182`	`182`	`foreach( $extra_rows as $col => &$col_values ) {`
`183`		`- $row_values[ $col ] = array_shift( $col_values );`
	`183`	`+ $row_values[ $col ] = ! empty( $col_values ) ? array_shift( $col_values ) : '';`
`184`	`184`	`if ( count( $col_values ) ) {`
`185`	`185`	`$has_more = true;`
`186`	`186`	`}`