Migrate Danger to use danger-pr-comment workflow#7
Merged
Conversation
dblock
force-pushed
the
migrate-danger-pr-comment
branch
3 times, most recently
from
96917cc to
ed3d79a
Compare
Updated to use the numbata/danger-pr-comment reusable workflow pattern, replacing manual Danger setup with cleaner workflow delegation. This brings the implementation in line with slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. Changes: - Updated danger.yml to use danger-run.yml reusable workflow - Added danger-comment.yml workflow for posting PR comments - Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check! - Added danger-pr-comment gem to Gemfile.danger - Updated Ruby version from 2.7 to 3.4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
force-pushed
the
migrate-danger-pr-comment
branch
from
ed3d79a to
4c48660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates Danger to use the
danger-pr-commentreusable workflow pattern, following the same approach as:Changes
.github/workflows/danger.ymlto usenumbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0.github/workflows/danger-comment.ymlworkflow for posting PR commentsDangerfileto importdanger-pr-commentgem and usechangelog.check!andtoc.check!danger-pr-commentgem toGemfile.dangerBenefits
🤖 Generated with Claude Code