Skip to content

Require Faraday 2.0.1 or greater (#554)#557

Merged
dblock merged 1 commit into
slack-ruby:masterfrom
AnrichVS:require-faraday-2.0.1
May 26, 2025
Merged

Require Faraday 2.0.1 or greater (#554)#557
dblock merged 1 commit into
slack-ruby:masterfrom
AnrichVS:require-faraday-2.0.1

Conversation

@AnrichVS

Copy link
Copy Markdown

Faraday version 2.0.0 had a bug that resulted in no default adapter being instantiated. This was fixed in version 2.0.1 - lostisland/faraday@5f88f8f

@dangerpr-bot

dangerpr-bot commented May 26, 2025

Copy link
Copy Markdown
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@AnrichVS AnrichVS force-pushed the require-faraday-2.0.1 branch from 7b4db90 to 1780578 Compare May 26, 2025 05:58
@coveralls

coveralls commented May 26, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15252262012

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.378%

Totals Coverage Status
Change from base Build 15227752789: 0.0%
Covered Lines: 5908
Relevant Lines: 6537

💛 - Coveralls

Faraday version 2.0.0 had a bug that resulted in no default adapter being instantiated. This was fixed in version 2.0.1 - lostisland/faraday@5f88f8f
@AnrichVS AnrichVS force-pushed the require-faraday-2.0.1 branch from fc8c4d0 to c0168ae Compare May 26, 2025 11:00
@dblock dblock merged commit ada6f96 into slack-ruby:master May 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants