From e85c5f178339b3399a7104fee9d4db684e57337e Mon Sep 17 00:00:00 2001 From: William Bergamin Date: Tue, 2 Sep 2025 15:31:17 -0400 Subject: [PATCH 1/2] fix: broken gradle CI --- .github/workflows/gradle.yml | 8 ++++---- .github/workflows/mvn.yml | 6 +++--- build.gradle | 11 ++++++++--- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index 576c664..c86e355 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -2,7 +2,7 @@ name: Lint & Test with Gradle on: push: - branches: [ main ] + branches: [main] pull_request: jobs: @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - java-version: ['11', '17'] + java-version: ["17", "21"] steps: - uses: actions/checkout@v4 @@ -18,8 +18,8 @@ jobs: uses: actions/setup-java@v4 with: java-version: ${{ matrix.java-version }} - distribution: 'adopt' + distribution: "adopt" - name: Lint run: gradle spotlessCheck - name: Build & Test - run: gradle test -x spotlessApply + run: gradle test -x spotlessApply --info diff --git a/.github/workflows/mvn.yml b/.github/workflows/mvn.yml index 6017aba..849e4bb 100644 --- a/.github/workflows/mvn.yml +++ b/.github/workflows/mvn.yml @@ -2,7 +2,7 @@ name: Lint & Test with Maven on: push: - branches: [ main ] + branches: [main] pull_request: jobs: @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - java-version: ['11', '17'] + java-version: ["11", "17", "21"] steps: - uses: actions/checkout@v4 @@ -18,7 +18,7 @@ jobs: uses: actions/setup-java@v4 with: java-version: ${{ matrix.java-version }} - distribution: 'adopt' + distribution: "adopt" - name: Lint run: mvn --batch-mode spotless:check - name: Build & Test diff --git a/build.gradle b/build.gradle index c442ed7..81ad70a 100644 --- a/build.gradle +++ b/build.gradle @@ -22,7 +22,8 @@ dependencies { // ***** OAUTH DEPENDENCIES ***** implementation("com.slack.api:bolt-jetty:1.45.3") // ***** TEST DEPENDENCIES ***** - testImplementation('org.junit.jupiter:junit-jupiter-engine:5.13.4') + testImplementation('org.junit.jupiter:junit-jupiter-api:5.13.4') + testRuntimeOnly('org.junit.jupiter:junit-jupiter-engine:5.13.4') testImplementation('org.mockito:mockito-core:5.18.0') } @@ -30,8 +31,12 @@ application { mainClass = 'Main' } -tasks.named('test') { - useJUnit() +testing { + suites { + test { + useJUnitJupiter() + } + } } spotless { From 40c49fe4ec7660dd4d4217db487f88cc2203f82a Mon Sep 17 00:00:00 2001 From: William Bergamin Date: Tue, 2 Sep 2025 15:34:02 -0400 Subject: [PATCH 2/2] use yaml list --- .github/workflows/gradle.yml | 4 +++- .github/workflows/mvn.yml | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index c86e355..14be5e2 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -10,7 +10,9 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - java-version: ["17", "21"] + java-version: + - 17 + - 21 steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/mvn.yml b/.github/workflows/mvn.yml index 849e4bb..d8a252c 100644 --- a/.github/workflows/mvn.yml +++ b/.github/workflows/mvn.yml @@ -10,7 +10,10 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - java-version: ["11", "17", "21"] + java-version: + - 11 + - 17 + - 21 steps: - uses: actions/checkout@v4