fix: broken gradle CI#378
Merged
Merged
Conversation
WilliamBergamin
added
bug
zimeg
approved these changes
Sep 2, 2025
zimeg
left a comment
zimeg
left a comment
Member
There was a problem hiding this comment.
@WilliamBergamin LGTM! And thanks for finding the time to keep these tests current and fast!
| // ***** TEST DEPENDENCIES ***** | ||
| testImplementation('org.junit.jupiter:junit-jupiter-engine:5.13.4') | ||
| testImplementation('org.junit.jupiter:junit-jupiter-api:5.13.4') | ||
| testRuntimeOnly('org.junit.jupiter:junit-jupiter-engine:5.13.4') |
Member
There was a problem hiding this comment.
🍀 praise: Nice find! I'm not sure of what makes a difference between runtime only test dependencies and test implementations, but it's interesting to find these separate packages.
| run: gradle spotlessCheck | ||
| - name: Build & Test | ||
| run: gradle test -x spotlessApply | ||
| run: gradle test -x spotlessApply --info |
Member
There was a problem hiding this comment.
👁️🗨️ praise: This is so useful for future debugging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change (place an x in the [ ] that applies)
Summary
The CI pipeline is currently reporting
Gradle requires JVM 17 or later to run. Your build is currently configured to use JVM 11.This aims to fix this issueRequirements