Skip to content

fix: broken gradle CI #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 3 commits into from
Sep 2, 2025
Merged

fix: broken gradle CI #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaf3d6b
fix: broken gradle CI
WilliamBergamin Sep 2, 2025
8609f0d
Update build.gradle
WilliamBergamin Sep 2, 2025
24a5ce0
add info logging to tests
WilliamBergamin Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java-version: ['11', '17']
java-version: ['17', '21']

steps:
- uses: actions/checkout@v4
Expand All @@ -22,4 +22,4 @@ jobs:
- name: Lint
run: gradle spotlessCheck
- name: Build & Test
run: gradle test -x spotlessApply
run: gradle test -x spotlessApply --info

@zimeg zimeg Sep 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ praise: This is so useful for future debugging!

2 changes: 1 addition & 1 deletion .github/workflows/mvn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java-version: ['11', '17']
java-version: ['11', '17', '21']

steps:
- uses: actions/checkout@v4
Expand Down
16 changes: 11 additions & 5 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
plugins {
id 'application'
id "com.diffplug.spotless" version "7.2.1"
id 'jvm-test-suite'
}

java {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

repositories {
Expand All @@ -22,16 +23,21 @@ dependencies {
// ***** OAUTH DEPENDENCIES *****
implementation("com.slack.api:bolt-jetty:1.45.3")
// ***** TEST DEPENDENCIES *****
testImplementation('org.junit.jupiter:junit-jupiter-engine:5.13.4')
testImplementation('org.junit.jupiter:junit-jupiter-api:5.13.4')
testRuntimeOnly('org.junit.jupiter:junit-jupiter-engine:5.13.4')

@zimeg zimeg Sep 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍀 praise: Nice find! I'm not sure of what makes a difference between runtime only test dependencies and test implementations, but it's interesting to find these separate packages.

testImplementation('org.mockito:mockito-core:5.18.0')
}

application {
mainClass = 'Main'
}

tasks.named('test') {
useJUnit()
testing {
suites {
test {
useJUnitJupiter()
}
}
}

spotless {
Expand Down