refactor: move feedback action to standalone path

Author: srtaalej

listeners/__init__.py

@@ -1,11 +1,11 @@
-from listeners.assistant import assistant
-from listeners.assistant.assistant import handle_feedback
+from listeners import actions
+from listeners import assistant
 
 
 def register_listeners(app):
-    # Using assistant middleware is the recommended way.
-    app.assistant(assistant)
-    app.action("feedback")(handle_feedback)
+
+    actions.register(app)
+    assistant.register(app)
 
     # The following event listeners demonstrate how to implement the same on your own.
     # from listeners import events

listeners/actions/__init__.py

@@ -0,0 +1,6 @@
+from slack_bolt import App
+from .actions import handle_feedback
+
+
+def register(app: App):
+    app.action("feedback")(handle_feedback)

listeners/actions/actions.py

@@ -0,0 +1,30 @@
+import logging
+
+
+# Handle feedback buttons (thumbs up/down)
+def handle_feedback(ack, body, client, logger: logging.Logger):
+    try:
+        ack()
+        message_ts = body["message"]["ts"]
+        channel_id = body["channel"]["id"]
+        feedback_type = body["actions"][0]["value"]
+        is_positive = feedback_type == "good-feedback"
+
+        if is_positive:
+            client.chat_postEphemeral(
+                channel=channel_id,
+                user=body["user"]["id"],
+                thread_ts=message_ts,
+                text="We're glad you found this useful.",
+            )
+        else:
+            client.chat_postEphemeral(
+                channel=channel_id,
+                user=body["user"]["id"],
+                thread_ts=message_ts,
+                text="Sorry to hear that response wasn't up to par :slightly_frowning_face: Starting a new chat may help with AI mistakes and hallucinations.",
+            )
+
+        logger.debug(f"Handled feedback: type={feedback_type}, message_ts={message_ts}")
+    except Exception as error:
+        logger.error(f":warning: Something went wrong! {error}")

listeners/assistant/__init__.py

@@ -1,3 +1,6 @@
+from slack_bolt import App
 from .assistant import assistant
 
-__all__ = ["assistant"]
+
+def register(app: App):
+    app.assistant(assistant)

listeners/assistant/assistant.py

@@ -3,25 +3,22 @@
 from slack_bolt import Assistant, BoltContext, Say, SetSuggestedPrompts
 from slack_bolt.context.get_thread_context import GetThreadContext
 from slack_sdk import WebClient
-from slack_sdk.models.blocks import FeedbackButtonsElement, FeedbackButtonObject, ContextActionsBlock
+from slack_sdk.models.blocks import Block, ContextActionsBlock, FeedbackButtonsElement, FeedbackButtonObject
 
 from ..llm_caller import call_llm
 
 # Refer to https://tools.slack.dev/bolt-python/concepts/assistant/ for more details
 assistant = Assistant()
 
 
-def create_feedback_block(user_id: str) -> ContextActionsBlock:
+def create_feedback_block() -> List[Block]:
     """
     Create feedback block with thumbs up/down buttons
 
-    Args:
-        user_id: User ID for user-specific controls
-
     Returns:
         Block Kit context_actions block
     """
-    block = [
+    blocks: List[Block] = [
         ContextActionsBlock(
             elements=[
                 FeedbackButtonsElement(
@@ -40,7 +37,7 @@ def create_feedback_block(user_id: str) -> ContextActionsBlock:
             ]
         )
     ]
-    return block
+    return blocks
 
 
 # This listener is invoked when a human user opened an assistant thread
@@ -93,7 +90,6 @@ def respond_in_assistant_thread(
     say: Say,
 ):
     try:
-        user_id = payload["user"]
         channel_id = payload["channel"]
         thread_ts = payload["thread_ts"]
 
@@ -135,38 +131,9 @@ def respond_in_assistant_thread(
             else:
                 continue
 
-        feedback_block = create_feedback_block(user_id=user_id)
+        feedback_block = create_feedback_block()
         client.chat_stopStream(channel=channel_id, ts=stream_ts, blocks=feedback_block)
 
     except Exception as e:
         logger.exception(f"Failed to handle a user message event: {e}")
         say(f":warning: Something went wrong! ({e})")
-
-
-# Handle feedback buttons (thumbs up/down)
-def handle_feedback(ack, body, client, logger):
-    ack()
-    try:
-        message_ts = body["message"]["ts"]
-        channel_id = body["channel"]["id"]
-        feedback_type = body["actions"][0]["value"]
-        is_positive = feedback_type == "good-feedback"
-
-        if is_positive:
-            client.chat_postEphemeral(
-                channel=channel_id,
-                user=body["user"]["id"],
-                thread_ts=message_ts,
-                text="We're glad you found this useful.",
-            )
-        else:
-            client.chat_postEphemeral(
-                channel=channel_id,
-                user=body["user"]["id"],
-                thread_ts=message_ts,
-                text="Sorry to hear that response wasn't up to par :slightly_frowning_face: Starting a new chat may help with AI mistakes and hallucinations.",
-            )
-
-        logger.debug(f"Handled feedback: type={feedback_type}, message_ts={message_ts}")
-    except Exception as error:
-        logger.error(f":warning: Something went wrong! {error}")