Skip to content

feat: improve the error handling logic #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 1 commit into from
Oct 8, 2025
Merged

feat: improve the error handling logic #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions listeners/functions/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,13 @@ def search_step_callback(ack: Ack, inputs: dict, fail: Fail, complete: Complete,
]

complete(outputs={"search_result": results})
except SlackResponseError as e:
logger.error(f"Failed to fetch or parse sample data. Error details: {str(e)}", exc_info=e)
fail(error=SEARCH_PROCESSING_ERROR_MSG)
except Exception as e:
logger.error(f"Unexpected error occurred while processing search request: {type(e).__name__} - {str(e)}", exc_info=e)
fail(error=SEARCH_PROCESSING_ERROR_MSG)
if isinstance(e, SlackResponseError):
logger.error(f"Failed to fetch or parse sample data. Error details: {str(e)}", exc_info=e)
fail(error=SEARCH_PROCESSING_ERROR_MSG)
else:
logger.error(
f"Unexpected error occurred while processing search request: {type(e).__name__} - {str(e)}", exc_info=e
)
finally:
ack()
5 changes: 1 addition & 4 deletions tests/listeners/functions/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,7 @@ def test_search_step_callback_unexpected_exception(self, mock_fetch_sample_data)
logger=self.mock_logger,
)

self.mock_fail.assert_called_once()
call_args = self.mock_fail.call_args
assert call_args.kwargs["error"] == SEARCH_PROCESSING_ERROR_MSG

self.mock_fail.assert_not_called()
self.mock_complete.assert_not_called()
self.mock_ack.assert_called_once()

Expand Down