feat: improve template behavior#7
Merged
Merged
Conversation
cchensh
reviewed
Oct 21, 2025
|
|
||
| LANGUAGES_FILTER = Filter( | ||
| name="languages", | ||
| display_name="Languages", |
Contributor
There was a problem hiding this comment.
Nit - can we also change here a bit to make display_name as Language and add display_name_plural as Languages?
Contributor
Author
There was a problem hiding this comment.
Yess let me add that in 💯
cchensh
reviewed
Oct 21, 2025
cchensh
approved these changes
Oct 21, 2025
cchensh
left a comment
cchensh
left a comment
Contributor
There was a problem hiding this comment.
Thank you @WilliamBergamin , the changes LGTM and it looks even cleaner, great job. Left small suggestion to add display_name_plural as optional attr for multi select filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
These changes improve the behavior of the template to leverage the toggle filter for templates and samples rather then the multi-select
Screen.Recording.2025-10-21.at.1.58.58.PM.mov
Requirements