chore: update biome configurations and applied settings (#2932)

Author: zimeg

biome.json

@@ -1,12 +1,12 @@
 {
   "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
   "files": {
-    "ignore": ["examples/**/dist"]
+    "includes": ["**", "!**/examples/**/dist"]
   },
   "formatter": {
     "enabled": true,
     "formatWithErrors": false,
-    "ignore": [],
+    "includes": ["**"],
     "attributePosition": "auto",
     "indentStyle": "space",
     "indentWidth": 2,
@@ -24,9 +24,26 @@
       "recommended": true
     }
   },
-  "organizeImports": {
-    "enabled": true
+  "assist": {
+    "actions": {
+      "source": {
+        "organizeImports": "on"
+      }
+    }
   },
+  "overrides": [
+    {
+      "includes": ["examples/**"],
+      "linter": {
+        "rules": {
+          "correctness": {
+            "noUnusedFunctionParameters": "off",
+            "noUnusedVariables": "off"
+          }
+        }
+      }
+    }
+  ],
   "vcs": {
     "enabled": true,
     "clientKind": "git",

examples/custom-receiver/src/FastifyReceiver.ts

@@ -4,16 +4,16 @@ import {
   type BufferedIncomingMessage,
   type CodedError,
   HTTPResponseAck,
+  HTTPModuleFunctions as httpFunc,
   type InstallProviderOptions,
   type InstallURLOptions,
   type Receiver,
   type ReceiverEvent,
   ReceiverInconsistentStateError,
   type ReceiverProcessEventErrorHandlerArgs,
   type ReceiverUnhandledRequestHandlerArgs,
-  HTTPModuleFunctions as httpFunc,
 } from '@slack/bolt';
-import { ConsoleLogger, type LogLevel, type Logger } from '@slack/logger';
+import { ConsoleLogger, type Logger, type LogLevel } from '@slack/logger';
 import { type CallbackOptions, type InstallPathOptions, InstallProvider } from '@slack/oauth';
 import Fastify, { type FastifyInstance } from 'fastify';
 
@@ -163,12 +163,7 @@ export default class FastifyReceiver implements Receiver {
 
   public init(app: App): void {
     this.app = app;
-    if (
-      this.installer &&
-      this.installerOptions &&
-      this.installerOptions.installPath &&
-      this.installerOptions.redirectUriPath
-    ) {
+    if (this.installer && this.installerOptions?.installPath && this.installerOptions.redirectUriPath) {
       this.fastify.get(this.installerOptions.installPath, async (req, res) => {
         await this.installer?.handleInstallPath(req.raw, res.raw, this.installerOptions?.installPathOptions);
       });

examples/custom-receiver/src/KoaReceiver.ts

@@ -1,20 +1,20 @@
-import { type Server, createServer } from 'node:http';
+import { createServer, type Server } from 'node:http';
 import Router from '@koa/router';
 import {
   type App,
   type BufferedIncomingMessage,
   type CodedError,
   HTTPResponseAck,
+  HTTPModuleFunctions as httpFunc,
   type InstallProviderOptions,
   type InstallURLOptions,
   type Receiver,
   type ReceiverEvent,
   ReceiverInconsistentStateError,
   type ReceiverProcessEventErrorHandlerArgs,
   type ReceiverUnhandledRequestHandlerArgs,
-  HTTPModuleFunctions as httpFunc,
 } from '@slack/bolt';
-import { ConsoleLogger, type LogLevel, type Logger } from '@slack/logger';
+import { ConsoleLogger, type Logger, type LogLevel } from '@slack/logger';
 import { type CallbackOptions, type InstallPathOptions, InstallProvider } from '@slack/oauth';
 import Koa from 'koa';
 
@@ -158,12 +158,7 @@ export default class KoaReceiver implements Receiver {
 
   public init(app: App): void {
     this.app = app;
-    if (
-      this.installer &&
-      this.installerOptions &&
-      this.installerOptions.installPath &&
-      this.installerOptions.redirectUriPath
-    ) {
+    if (this.installer && this.installerOptions?.installPath && this.installerOptions.redirectUriPath) {
       this.router.get(this.installerOptions.installPath, async (ctx) => {
         await this.installer?.handleInstallPath(ctx.req, ctx.res, this.installerOptions?.installPathOptions);
       });

package-lock.json

@@ -58,7 +58,7 @@
     "tsscmp": "^1.0.6"
   },
   "devDependencies": {
-    "@biomejs/biome": "^1.9.0",
+    "@biomejs/biome": "^2.4.15",
     "@changesets/cli": "^2.29.8",
     "@tsconfig/node20": "^20.1.5",
     "@types/chai": "^4.1.7",

package.json

@@ -1,13 +1,13 @@
 import util from 'node:util';
-import { ConsoleLogger, LogLevel, type Logger } from '@slack/logger';
+import { ConsoleLogger, type Logger, LogLevel } from '@slack/logger';
 import {
+  addAppMetadata,
   type FetchFunction,
   WebAPIHTTPError,
   WebAPIPlatformError,
   WebAPIRateLimitedError,
   WebClient,
   type WebClientOptions,
-  addAppMetadata,
 } from '@slack/web-api';
 import type { Assistant } from './Assistant';
 import {
@@ -23,24 +23,25 @@ import {
   createSay,
   createSayStream,
   createSetStatus,
+  type SayStreamFn,
+  type SetStatusFn,
 } from './context';
-import type { SayStreamFn, SetStatusFn } from './context';
-import { type ConversationStore, MemoryStore, conversationContext } from './conversation-store';
+import { type ConversationStore, conversationContext, MemoryStore } from './conversation-store';
 import {
   AppInitializationError,
   AuthorizationError,
+  asCodedError,
   type CodedError,
   InvalidCustomPropertyError,
   MultipleListenerError,
-  asCodedError,
 } from './errors';
 import {
-  IncomingEventType,
   assertNever,
   extractEventChannelId,
   extractEventThreadTs,
   extractEventTs,
   getTypeAndConversation,
+  IncomingEventType,
   isBodyWithTypeEnterpriseInstall,
   isEventTypeToSkipAuthorize,
 } from './helpers';
@@ -99,7 +100,8 @@ import type {
   ViewOutput,
 } from './types';
 import { contextBuiltinKeys } from './types';
-import { type StringIndexed, isRejected } from './types/utilities';
+import { isRejected, type StringIndexed } from './types/utilities';
+
 const packageJson = require('../package.json');
 
 export type { ActionConstraints, OptionsConstraints, ShortcutConstraints, ViewConstraints } from './types';
@@ -155,7 +157,7 @@ export interface AppOptions {
   attachFunctionToken?: boolean;
 }
 
-export { LogLevel, Logger } from '@slack/logger';
+export { Logger, LogLevel } from '@slack/logger';
 
 /** Authorization function - seeds the middleware processing and listeners with an authorization context */
 export type Authorize<IsEnterpriseInstall extends boolean = false> = (
@@ -1051,7 +1053,7 @@ export default class App<AppCustomContext extends StringIndexed = StringIndexed>
 
     // TODO: this logic should be isolated and tested according to the expected behavior
     if (token !== undefined) {
-      let pool: WebClientPool | undefined = undefined;
+      let pool: WebClientPool | undefined;
       const clientOptionsCopy = { ...this.clientOptions };
       if (authorizeResult.teamId !== undefined) {
         pool = this.clients[authorizeResult.teamId];
@@ -1196,7 +1198,6 @@ export default class App<AppCustomContext extends StringIndexed = StringIndexed>
           const rejectedListenerResults = settledListenerResults.filter(isRejected);
           if (rejectedListenerResults.length === 1) {
             throw rejectedListenerResults[0].reason;
-            // biome-ignore lint/style/noUselessElse: I think this is a biome issue actually...
           } else if (rejectedListenerResults.length > 1) {
             throw new MultipleListenerError(rejectedListenerResults.map((rlr) => rlr.reason));
           }
@@ -1323,15 +1324,15 @@ export default class App<AppCustomContext extends StringIndexed = StringIndexed>
       throw new AppInitializationError(
         `${tokenUsage} \n\nSince you have not provided a token or authorize, you might be missing one or more required oauth installer options. See https://docs.slack.dev/tools/bolt-js/concepts/authenticating-oauth/ for these required fields.\n`,
       );
-      // biome-ignore lint/style/noUselessElse: I think this is a biome issue actually...
-    } else if (authorize !== undefined && usingOauth) {
+    }
+    if (authorize !== undefined && usingOauth) {
       throw new AppInitializationError(`You cannot provide both authorize and oauth installer options. ${tokenUsage}`);
-      // biome-ignore lint/style/noUselessElse: I think this is a biome issue actually...
-    } else if (authorize === undefined && usingOauth) {
+    }
+    if (authorize === undefined && usingOauth) {
       // biome-ignore lint/style/noNonNullAssertion: we know installer is truthy here
       return httpReceiver.installer!.authorize;
-      // biome-ignore lint/style/noUselessElse: I think this is a biome issue actually...
-    } else if (authorize !== undefined && !usingOauth) {
+    }
+    if (authorize !== undefined && !usingOauth) {
       return authorize as Authorize<boolean>;
     }
     return undefined;
@@ -1623,9 +1624,9 @@ function escapeHtml(input: string | undefined | null): string {
 }
 
 function extractFunctionContext(body: StringIndexed) {
-  let functionExecutionId: string | undefined = undefined;
-  let functionBotAccessToken: string | undefined = undefined;
-  let functionInputs: FunctionInputs | undefined = undefined;
+  let functionExecutionId: string | undefined;
+  let functionBotAccessToken: string | undefined;
+  let functionInputs: FunctionInputs | undefined;
 
   // function_executed event
   if (body.event && body.event.type === 'function_executed' && body.event.function_execution_id) {