From 171bad7fff821de8830af69cbaa297b69f5d94e9 Mon Sep 17 00:00:00 2001
From: "Xql.dev" <205849173+KirobotDev@users.noreply.github.com>
Date: Wed, 8 Apr 2026 20:02:00 +0700
Subject: [PATCH] fix: correct InvalidCustomPropertyError code and MemoryStore
 promise handling

- InvalidCustomPropertyError now uses ErrorCode.InvalidCustomPropertyError instead of AppInitializationError
- MemoryStore.get() adds return statements after resolve/reject to prevent promise double settlement
---
 src/conversation-store.ts | 2 ++
 src/errors.ts             | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/conversation-store.ts b/src/conversation-store.ts
index 6212df663..6d17c68f0 100644
--- a/src/conversation-store.ts
+++ b/src/conversation-store.ts
@@ -36,8 +36,10 @@ export class MemoryStore<ConversationState = any> implements ConversationStore<C
           // release the memory
           this.state.delete(conversationId);
           reject(new Error('Conversation expired'));
+          return;
         }
         resolve(entry.value);
+        return;
       }
       reject(new Error('Conversation not found'));
     });
diff --git a/src/errors.ts b/src/errors.ts
index 582aea969..ef250b44c 100644
--- a/src/errors.ts
+++ b/src/errors.ts
@@ -106,7 +106,7 @@ export class ContextMissingPropertyError extends Error implements CodedError {
 }
 
 export class InvalidCustomPropertyError extends Error implements CodedError {
-  public code = ErrorCode.AppInitializationError;
+  public code = ErrorCode.InvalidCustomPropertyError;
 }
 
 export class CustomRouteInitializationError extends Error implements CodedError {