simplify unit tests

Author: WilliamBergamin

tests/slack_bolt/middleware/attaching_agent_kwargs/test_attaching_agent_kwargs.py

@@ -22,22 +22,20 @@ def test_assistant_event_attaches_kwargs(self):
         middleware = AttachingAgentKwargs()
         req = BoltRequest(body=thread_started_event_body, mode="socket_mode")
         req.context["client"] = WebClient(token="xoxb-test")
-        resp = BoltResponse(status=404)
 
-        resp = middleware.process(req=req, resp=resp, next=next)
+        resp = middleware.process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
             assert key in req.context, f"{key} should be set on context"
         assert req.context["say"].thread_ts == "1726133698.626339"
 
-    def test_user_message_assistant_event_attaches_kwargs(self):
+    def test_user_message_event_attaches_kwargs(self):
         middleware = AttachingAgentKwargs()
         req = BoltRequest(body=user_message_event_body, mode="socket_mode")
         req.context["client"] = WebClient(token="xoxb-test")
-        resp = BoltResponse(status=404)
 
-        resp = middleware.process(req=req, resp=resp, next=next)
+        resp = middleware.process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
@@ -48,41 +46,19 @@ def test_non_assistant_event_does_not_attach_kwargs(self):
         middleware = AttachingAgentKwargs()
         req = BoltRequest(body=channel_user_message_event_body, mode="socket_mode")
         req.context["client"] = WebClient(token="xoxb-test")
-        resp = BoltResponse(status=404)
 
-        resp = middleware.process(req=req, resp=resp, next=next)
+        resp = middleware.process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
             assert key not in req.context, f"{key} should not be set on context"
 
-    def test_non_event_body_does_not_attach_kwargs(self):
+    def test_non_event_does_not_attach_kwargs(self):
         middleware = AttachingAgentKwargs()
         req = BoltRequest(body="payload={}", headers={})
-        resp = BoltResponse(status=404)
 
-        resp = middleware.process(req=req, resp=resp, next=next)
+        resp = middleware.process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
             assert key not in req.context, f"{key} should not be set on context"
-
-    def test_next_always_called(self):
-        middleware = AttachingAgentKwargs()
-        call_state = {"called": False}
-
-        def tracking_next():
-            call_state["called"] = True
-            return BoltResponse(status=200)
-
-        # With assistant event
-        req = BoltRequest(body=thread_started_event_body, mode="socket_mode")
-        req.context["client"] = WebClient(token="xoxb-test")
-        middleware.process(req=req, resp=BoltResponse(status=404), next=tracking_next)
-        assert call_state["called"] is True
-
-        # With non-event body
-        call_state["called"] = False
-        req = BoltRequest(body="payload={}", headers={})
-        middleware.process(req=req, resp=BoltResponse(status=404), next=tracking_next)
-        assert call_state["called"] is True

tests/slack_bolt_async/middleware/attaching_agent_kwargs/test_async_attaching_agent_kwargs.py

@@ -24,23 +24,21 @@ async def test_assistant_event_attaches_kwargs(self):
         middleware = AsyncAttachingAgentKwargs()
         req = AsyncBoltRequest(body=thread_started_event_body, mode="socket_mode")
         req.context["client"] = AsyncWebClient(token="xoxb-test")
-        resp = BoltResponse(status=404)
 
-        resp = await middleware.async_process(req=req, resp=resp, next=next)
+        resp = await middleware.async_process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
             assert key in req.context, f"{key} should be set on context"
         assert req.context["say"].thread_ts == "1726133698.626339"
 
     @pytest.mark.asyncio
-    async def test_user_message_assistant_event_attaches_kwargs(self):
+    async def test_user_message_event_attaches_kwargs(self):
         middleware = AsyncAttachingAgentKwargs()
         req = AsyncBoltRequest(body=user_message_event_body, mode="socket_mode")
         req.context["client"] = AsyncWebClient(token="xoxb-test")
-        resp = BoltResponse(status=404)
 
-        resp = await middleware.async_process(req=req, resp=resp, next=next)
+        resp = await middleware.async_process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
@@ -52,43 +50,20 @@ async def test_non_assistant_event_does_not_attach_kwargs(self):
         middleware = AsyncAttachingAgentKwargs()
         req = AsyncBoltRequest(body=channel_user_message_event_body, mode="socket_mode")
         req.context["client"] = AsyncWebClient(token="xoxb-test")
-        resp = BoltResponse(status=404)
 
-        resp = await middleware.async_process(req=req, resp=resp, next=next)
+        resp = await middleware.async_process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
             assert key not in req.context, f"{key} should not be set on context"
 
     @pytest.mark.asyncio
-    async def test_non_event_body_does_not_attach_kwargs(self):
+    async def test_non_event_does_not_attach_kwargs(self):
         middleware = AsyncAttachingAgentKwargs()
         req = AsyncBoltRequest(body="payload={}", headers={})
-        resp = BoltResponse(status=404)
 
-        resp = await middleware.async_process(req=req, resp=resp, next=next)
+        resp = await middleware.async_process(req=req, resp=BoltResponse(status=404), next=next)
 
         assert resp.status == 200
         for key in AGENT_KWARGS:
             assert key not in req.context, f"{key} should not be set on context"
-
-    @pytest.mark.asyncio
-    async def test_next_always_called(self):
-        middleware = AsyncAttachingAgentKwargs()
-        call_state = {"called": False}
-
-        async def tracking_next():
-            call_state["called"] = True
-            return BoltResponse(status=200)
-
-        # With assistant event
-        req = AsyncBoltRequest(body=thread_started_event_body, mode="socket_mode")
-        req.context["client"] = AsyncWebClient(token="xoxb-test")
-        await middleware.async_process(req=req, resp=BoltResponse(status=404), next=tracking_next)
-        assert call_state["called"] is True
-
-        # With non-event body
-        call_state["called"] = False
-        req = AsyncBoltRequest(body="payload={}", headers={})
-        await middleware.async_process(req=req, resp=BoltResponse(status=404), next=tracking_next)
-        assert call_state["called"] is True