refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs#1473
refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs#1473WilliamBergamin merged 1 commit intomainfrom
Conversation
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM and thanks for discussion prior to these changes 🤓
I'm approving quick with a question of eventual changes - would the say argument find eventual place in these kwargs? I understand this can be a breaking change but I am curious now:
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 229 229
Lines 7270 7270
=======================================
Hits 6639 6639
Misses 631 631 ☔ View full report in Codecov by Sentry. |
Yess hopefully |
Summary
This PR aims to move away from the "agent" terminology by renaming the
AttachingAgentKwargsmiddleware toAttachingConversationKwargsPlease feel free to share any other naming ideas 🤔
Testing
CI tests should be sufficient
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.