Skip to content

refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs#1473

Merged
WilliamBergamin merged 1 commit intomainfrom
rename-agent-middleware
Apr 1, 2026
Merged

refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs#1473
WilliamBergamin merged 1 commit intomainfrom
rename-agent-middleware

Conversation

@WilliamBergamin
Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin commented Apr 1, 2026

Summary

This PR aims to move away from the "agent" terminology by renaming the AttachingAgentKwargs middleware to AttachingConversationKwargs

Please feel free to share any other naming ideas 🤔

Testing

CI tests should be sufficient

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added this to the 1.28.0 milestone Apr 1, 2026
@WilliamBergamin WilliamBergamin self-assigned this Apr 1, 2026
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner April 1, 2026 18:38
zimeg
zimeg approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin LGTM and thanks for discussion prior to these changes 🤓

I'm approving quick with a question of eventual changes - would the say argument find eventual place in these kwargs? I understand this can be a breaking change but I am curious now:

bolt-python/slack_bolt/kwargs_injection/args.py

Line 165 in 39007db

self.say: Say = say

@zimeg zimeg changed the title chore: rename AttachingAgentKwargs middleware to AttachingConversationKwargs refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (8908885) to head (39007db).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         229      229           
  Lines        7270     7270           
=======================================
  Hits         6639     6639           
  Misses        631      631

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergamin
Copy link
Copy Markdown
Contributor Author

WilliamBergamin commented Apr 1, 2026 •
edited
Loading

I'm approving quick with a question of eventual changes - would the say argument find eventual place in these kwargs? I understand this can be a breaking change but I am curious now:

Yess hopefully say can be brought in this middleware as well in the future 🚀

@WilliamBergamin WilliamBergamin merged commit 9d0e0af into main Apr 1, 2026
16 checks passed
@WilliamBergamin WilliamBergamin deleted the rename-agent-middleware branch April 1, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

@srtaalej srtaalej Awaiting requested review from srtaalej

Assignees

@WilliamBergamin WilliamBergamin

Labels

area:async area:sync semver:patch

Projects

None yet

Milestone

1.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliamBergamin @zimeg