Revert "Add @required annotation with optional validator (#1558)" (#1566)

This reverts commit 372fff8.

Author: WilliamBergamin

slack-api-client/src/main/java/com/slack/api/SlackConfig.java

@@ -62,9 +62,6 @@ public void setFailOnUnknownProperties(boolean failOnUnknownProperties) {
             throwException();
         }
 
-        @Override
-        public void setFailOnRequiredProperties(boolean failOnRequiredProperties) { throwException(); }
-
         @Override
         public void setPrettyResponseLoggingEnabled(boolean prettyResponseLoggingEnabled) {
             throwException();
@@ -251,11 +248,6 @@ public void setLibraryMaintainerMode(boolean libraryMaintainerMode) {
      */
     private boolean failOnUnknownProperties = false;
 
-    /**
-     * If you would like to detect required properties by throwing exceptions, set this flag as true.
-     */
-    private boolean failOnRequiredProperties = false;
-
     /**
      * Slack Web API client verifies the existence of tokens before sending HTTP requests to Slack servers.
      */

slack-api-client/src/main/java/com/slack/api/util/json/GsonFactory.java

@@ -44,17 +44,12 @@ public static Gson createSnakeCase(SlackConfig config) {
         GsonBuilder gsonBuilder = new GsonBuilder()
                 .setFieldNamingPolicy(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES);
         registerTypeAdapters(gsonBuilder, failOnUnknownProps);
-
         if (failOnUnknownProps || config.isLibraryMaintainerMode()) {
-            gsonBuilder.registerTypeAdapterFactory(new UnknownPropertyDetectionAdapterFactory());
-        }
-        if (config.isFailOnRequiredProperties()) {
-            gsonBuilder.registerTypeAdapterFactory(new RequiredPropertyDetectionAdapterFactory());
+            gsonBuilder = gsonBuilder.registerTypeAdapterFactory(new UnknownPropertyDetectionAdapterFactory());
         }
         if (config.isPrettyResponseLoggingEnabled()) {
-            gsonBuilder.setPrettyPrinting();
+            gsonBuilder = gsonBuilder.setPrettyPrinting();
         }
-
         return gsonBuilder.create();
     }
 
@@ -65,17 +60,12 @@ public static Gson createCamelCase(SlackConfig config) {
         boolean failOnUnknownProps = config.isFailOnUnknownProperties();
         GsonBuilder gsonBuilder = new GsonBuilder();
         registerTypeAdapters(gsonBuilder, failOnUnknownProps);
-
         if (failOnUnknownProps || config.isLibraryMaintainerMode()) {
-            gsonBuilder.registerTypeAdapterFactory(new UnknownPropertyDetectionAdapterFactory());
-        }
-        if (config.isFailOnRequiredProperties()) {
-            gsonBuilder.registerTypeAdapterFactory(new RequiredPropertyDetectionAdapterFactory());
+            gsonBuilder = gsonBuilder.registerTypeAdapterFactory(new UnknownPropertyDetectionAdapterFactory());
         }
         if (config.isPrettyResponseLoggingEnabled()) {
-            gsonBuilder.setPrettyPrinting();
+            gsonBuilder = gsonBuilder.setPrettyPrinting();
         }
-
         return gsonBuilder.create();
     }
 

slack-api-model/src/main/java/com/slack/api/util/annotation/Required.java

@@ -27,19 +27,7 @@ public static Gson createSnakeCaseWithoutUnknownPropertyDetection(boolean failOn
         return createSnakeCase(failOnUnknownProperties, false);
     }
 
-    public static Gson createSnakeCaseWithRequiredPropertyDetection() {
-        return createSnakeCase(false, true, true);
-    }
-
     public static Gson createSnakeCase(boolean failOnUnknownProperties, boolean unknownPropertyDetection) {
-        return createSnakeCase(failOnUnknownProperties, unknownPropertyDetection, false);
-    }
-
-    public static Gson createSnakeCase(
-            boolean failOnUnknownProperties,
-            boolean unknownPropertyDetection,
-            boolean failOnRequiredProperties
-    ) {
         GsonBuilder builder = new GsonBuilder()
                 .setFieldNamingPolicy(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES)
                 .registerTypeAdapter(File.class, new GsonFileFactory(failOnUnknownProperties))
@@ -57,12 +45,9 @@ public static Gson createSnakeCase(
                         new GsonMessageChangedEventPreviousMessageFactory(failOnUnknownProperties));
 
         if (unknownPropertyDetection) {
-            builder.registerTypeAdapterFactory(new UnknownPropertyDetectionAdapterFactory());
-        }
-        if (failOnRequiredProperties) {
-            builder.registerTypeAdapterFactory(new RequiredPropertyDetectionAdapterFactory());
+            return builder.registerTypeAdapterFactory(new UnknownPropertyDetectionAdapterFactory()).create();
+        } else {
+            return builder.create();
         }
-
-        return builder.create();
     }
 }