Skip to content

Commit b6ae5f6

Browse files
committed
Add a test verifying #451
1 parent 5743a92 commit b6ae5f6

3 files changed

Lines changed: 25 additions & 3 deletions

File tree

slack-api-client/src/main/java/com/slack/api/rtm/RTMEventHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ public String getEventType() {
3838
/**
3939
* Returns the subtype value of the event (e.g., MessageEvent.TYPE_NAME)
4040
*/
41-
public String getEventSubType()
42-
{
41+
public String getEventSubType() {
4342
if (cachedEventSubName != null) {
4443
return cachedEventSubName;
4544
}

slack-api-client/src/test/java/test_locally/api/methods_admin_api/AdminApiAsyncTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.slack.api.Slack;
44
import com.slack.api.SlackConfig;
55
import com.slack.api.methods.AsyncMethodsClient;
6-
import com.slack.api.methods.MethodsClient;
76
import org.junit.After;
87
import org.junit.Before;
98
import org.junit.Test;

slack-api-client/src/test/java/test_with_remote_apis/methods/rtm_Test.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55
import com.slack.api.Slack;
66
import com.slack.api.SlackConfig;
77
import com.slack.api.methods.SlackApiException;
8+
import com.slack.api.methods.response.chat.ChatPostMessageResponse;
89
import com.slack.api.methods.response.conversations.ConversationsInviteResponse;
910
import com.slack.api.model.Conversation;
1011
import com.slack.api.model.User;
1112
import com.slack.api.model.event.HelloEvent;
13+
import com.slack.api.model.event.MessageBotEvent;
1214
import com.slack.api.model.event.UserTypingEvent;
1315
import com.slack.api.rtm.*;
1416
import com.slack.api.rtm.message.Message;
@@ -68,6 +70,17 @@ public void handle(HelloEvent event) {
6870
}
6971
}
7072

73+
@Slf4j
74+
public static class BotMessageHandler extends RTMEventHandler<MessageBotEvent> {
75+
public final AtomicInteger counter = new AtomicInteger(0);
76+
77+
@Override
78+
public void handle(MessageBotEvent event) {
79+
log.info("bot message event: {}", event);
80+
counter.incrementAndGet();
81+
}
82+
}
83+
7184
public static class SubHelloHandler extends HelloHandler {
7285
}
7386

@@ -109,6 +122,16 @@ public void test() throws Exception {
109122
assertThat(hello.counter.get(), is(1));
110123
assertThat(hello2.counter.get(), is(1));
111124

125+
BotMessageHandler bot = new BotMessageHandler();
126+
dispatcher.register(bot);
127+
128+
ChatPostMessageResponse chatPostMessage = slack.methods(classicAppBotToken)
129+
.chatPostMessage(r -> r.channel(channelId).text("Hi!"));
130+
assertThat(chatPostMessage.getError(), is(nullValue()));
131+
132+
Thread.sleep(1000L);
133+
assertThat(bot.counter.get(), is(1));
134+
112135
rtm.reconnect();
113136
Thread.sleep(1000L);
114137
assertThat(hello.counter.get(), is(2));
@@ -120,6 +143,7 @@ public void test() throws Exception {
120143
Thread.sleep(1000L);
121144
assertThat(hello.counter.get(), is(2)); // should not be incremented
122145
assertThat(hello2.counter.get(), is(3));
146+
123147
}
124148

125149
} finally {

0 commit comments

Comments
 (0)