Skip to content

Commit dc13df5

Browse files
committed
adjust buffer size
1 parent a919689 commit dc13df5

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

slack-api-client/src/main/java/com/slack/api/methods/AsyncChatStreamHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public enum State {
4141
private final String recipientUserId;
4242

4343
@Builder.Default
44-
private final int bufferSize = 100;
44+
private final int bufferSize = 256;
4545

4646
@Builder.Default
4747
private StringBuilder buffer = new StringBuilder();

slack-api-client/src/test/java/test_locally/api/methods/AsyncChatStreamHelperTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public void append_buffers_when_under_bufferSize() throws Exception {
4545
AsyncChatStreamHelper stream = slack.methodsAsync(ValidToken).asyncChatStreamHelper(req -> req
4646
.channel("C123")
4747
.threadTs("123.123")
48-
.bufferSize(100));
48+
.bufferSize(256));
4949

5050
ChatAppendStreamResponse resp = stream.append("hello").get();
5151
assertThat(resp, is(nullValue()));
@@ -168,18 +168,18 @@ public void stop_after_stream_already_started() throws Exception {
168168
}
169169

170170
@Test
171-
public void default_buffer_size_is_100() {
171+
public void default_buffer_size_is_256() {
172172
AsyncChatStreamHelper stream = slack.methodsAsync(ValidToken).asyncChatStreamHelper(req -> req
173173
.channel("C123"));
174174

175-
assertThat(stream.getBufferSize(), is(100));
175+
assertThat(stream.getBufferSize(), is(256));
176176
}
177177

178178
@Test
179179
public void multiple_appends_accumulate_in_buffer() throws Exception {
180180
AsyncChatStreamHelper stream = slack.methodsAsync(ValidToken).asyncChatStreamHelper(req -> req
181181
.channel("C123")
182-
.bufferSize(100));
182+
.bufferSize(256));
183183

184184
stream.append("hello").get();
185185
stream.append(" ").get();

slack-api-client/src/test/java/test_locally/api/methods/ChatStreamHelperTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void append_buffers_when_under_bufferSize() throws Exception {
4444
ChatStreamHelper stream = slack.methods(ValidToken).chatStreamHelper(req -> req
4545
.channel("C123")
4646
.threadTs("123.123")
47-
.bufferSize(100));
47+
.bufferSize(256));
4848

4949
ChatAppendStreamResponse resp = stream.append("hello");
5050
assertThat(resp, is(nullValue()));
@@ -177,18 +177,18 @@ public void stop_after_stream_already_started() throws Exception {
177177
}
178178

179179
@Test
180-
public void default_buffer_size_is_100() {
180+
public void default_buffer_size_is_256() {
181181
ChatStreamHelper stream = slack.methods(ValidToken).chatStreamHelper(req -> req
182182
.channel("C123"));
183183

184-
assertThat(stream.getBufferSize(), is(100));
184+
assertThat(stream.getBufferSize(), is(256));
185185
}
186186

187187
@Test
188188
public void multiple_appends_accumulate_in_buffer() throws Exception {
189189
ChatStreamHelper stream = slack.methods(ValidToken).chatStreamHelper(req -> req
190190
.channel("C123")
191-
.bufferSize(100));
191+
.bufferSize(256));
192192

193193
stream.append("hello");
194194
stream.append(" ");

0 commit comments

Comments
 (0)