requestSharedInvite approve/deny/list sample JSON payloads#1333
requestSharedInvite approve/deny/list sample JSON payloads#1333filmaj wants to merge 51 commits intoslack-connect-invite-automationfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## slack-connect-invite-automation #1333 +/- ##
=====================================================================
- Coverage 74.95% 74.81% -0.14%
- Complexity 4186 4273 +87
=====================================================================
Files 451 457 +6
Lines 12930 13276 +346
Branches 1331 1369 +38
=====================================================================
+ Hits 9692 9933 +241
- Misses 2466 2545 +79
- Partials 772 798 +26 ☔ View full report in Codecov by Sentry. |
seratch
left a comment
There was a problem hiding this comment.
Having error properties is recommended, but if you need this anyways, you can go ahead
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "ok": true, | |||
| "invite_id": "I1234" | |||
There was a problem hiding this comment.
Like other APIs, "error": "", and "response_metadata": { ... } (response_metadata does not always exist tho) should exist for error patterns. That said, if you need only these properties so far, it's okay to go ahead with it.
|
@filmaj If you just want to generate the response type, you can manually add it for now. Once the response data structure is finalized and this repo's main branch supports it, the manually crafted one will be automatically replaced by the quicktype script then. |
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.2. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.8...v3.3.2) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dV2 (#1346) Co-authored-by: Eden Zimbelman <zim@o526.net>
fd1f298 to
9f8f1d2
Compare
These are samples for the following APIs (only available in dev right now):
conversations.requestSharedInvite.listconversations.requestSharedInvite.denyconversations.requestSharedInvite.approveI am issuing this PR to the
slack-connect-invite-automationbranch as a base, as these APIs are being piloted and should not be merged intomainuntil after the customer pilot for these APIs is complete.