Skip to content

requestSharedInvite approve/deny/list sample JSON payloads#1333

Closed
filmaj wants to merge 51 commits intoslack-connect-invite-automationfrom
scia-json-samples
Closed

requestSharedInvite approve/deny/list sample JSON payloads#1333
filmaj wants to merge 51 commits intoslack-connect-invite-automationfrom
scia-json-samples

Conversation

@filmaj
Copy link
Copy Markdown
Contributor

@filmaj filmaj commented Jul 4, 2024

These are samples for the following APIs (only available in dev right now):

  • conversations.requestSharedInvite.list
  • conversations.requestSharedInvite.deny
  • conversations.requestSharedInvite.approve

I am issuing this PR to the slack-connect-invite-automation branch as a base, as these APIs are being piloted and should not be merged into main until after the customer pilot for these APIs is complete.

@filmaj filmaj added the project:slack-api-client project:slack-api-client label Jul 4, 2024
@filmaj filmaj requested a review from seratch July 4, 2024 19:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 71.06918% with 46 lines in your changes missing coverage. Please review.

Project coverage is 74.81%. Comparing base (d8eb0d2) to head (9f8f1d2).

Files with missing lines Patch % Lines
...ck/api/bolt/jakarta_socket_mode/SocketModeApp.java 62.50% 28 Missing and 5 partials ⚠️
bolt/src/main/java/com/slack/api/bolt/App.java 57.14% 2 Missing and 4 partials ⚠️
...m/slack/api/bolt/request/builtin/EventRequest.java 57.14% 0 Missing and 3 partials ⚠️
...ck/api/bolt/request/builtin/ViewClosedRequest.java 33.33% 1 Missing and 1 partial ⚠️
.../main/java/com/slack/api/bolt/context/Context.java 83.33% 0 Missing and 1 partial ⚠️
...k/api/bolt/request/builtin/BlockActionRequest.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##             slack-connect-invite-automation    #1333      +/-   ##
=====================================================================
- Coverage                              74.95%   74.81%   -0.14%     
- Complexity                              4186     4273      +87     
=====================================================================
  Files                                    451      457       +6     
  Lines                                  12930    13276     +346     
  Branches                                1331     1369      +38     
=====================================================================
+ Hits                                    9692     9933     +241     
- Misses                                  2466     2545      +79     
- Partials                                 772      798      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having error properties is recommended, but if you need this anyways, you can go ahead

@@ -0,0 +1,4 @@
{
"ok": true,
"invite_id": "I1234"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like other APIs, "error": "", and "response_metadata": { ... } (response_metadata does not always exist tho) should exist for error patterns. That said, if you need only these properties so far, it's okay to go ahead with it.

@seratch seratch added this to the 1.x milestone Jul 4, 2024
@seratch
Copy link
Copy Markdown
Contributor

seratch commented Jul 4, 2024

@filmaj If you just want to generate the response type, you can manually add it for now. Once the response data structure is finalized and this repo's main branch supports it, the manually crafted one will be automatically replaced by the quicktype script then.

seratch and others added 23 commits July 8, 2024 14:52
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.2.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.2.8...v3.3.2)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@filmaj filmaj force-pushed the scia-json-samples branch from fd1f298 to 9f8f1d2 Compare August 28, 2024 14:04
@filmaj filmaj changed the title requestSharedInvite approve/deny sample JSON payloads. requestSharedInvite approve/deny/list sample JSON payloads Aug 28, 2024
@seratch seratch closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants