fix filename & title getting improperly defaulted in filesUploadV2#1346
fix filename & title getting improperly defaulted in filesUploadV2#1346seratch merged 6 commits intoslackapi:mainfrom Cheos137:fix-MethodsClientImpl-filesUploadV2
Conversation
…iple files using MethodsClientImpl#filesUploadV2
|
Thanks for the contribution! Before we can merge this, we need @Cheos137 to sign the Salesforce Inc. Contributor License Agreement. |
zimeg
added
bug
|
Hi @Cheos137! 👋 Thank you for taking the time to send in this PR and sign the CLA! This logic is looking solid to me but we might want to include a test to ensure this behavior is correct and doesn't regress in future changes 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
=========================================
Coverage 74.98% 74.99%
Complexity 4189 4189
=========================================
Files 451 451
Lines 12930 12929 -1
Branches 1331 1331
=========================================
Hits 9696 9696
+ Misses 2463 2462 -1
Partials 771 771 ☔ View full report in Codecov by Sentry. |
these tests check the handling and defaulting of filename and title when using filesUploadV2, specifically when uploading multiple files / using JUST the uploadFiles parameter
|
cuz i suspect there might not have gone out a notification from it: yesterday i've added tests to this pr |
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
Thanks a ton for adding the tests! Once these are passing I think the PR will be in a solid spot 🙏
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
This is looking solid! I did leave one question about the defaults being tested that I'm unsure of myself- let me know if setting specific strings seems right 🧵 👀
i seem to have been really sleepy when writing them Co-authored-by: Eden Zimbelman <zim@o526.net>
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📝 🎶 A few more notes, but thank you for the fast fixes already!
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thank you so much for fixing this! Looks great to me 👍
3 participants
fix filename & title getting improperly defaulted when uploading multiple files using MethodsClientImpl#filesUploadV2
fixes #1345
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.