-
Notifications
You must be signed in to change notification settings - Fork 228
feat: update work object types #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+49
−5
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -129,6 +129,13 @@ public static class TypedField { | |
|
|
||
| // When type is 'slack#/types/user' | ||
| private User user; | ||
|
|
||
| // When type is 'slack#/types/entity_ref' | ||
| private EntityRef entityRef; | ||
|
|
||
| // When type is 'boolean' | ||
| @SerializedName("boolean") | ||
| private BooleanField booleanField; | ||
| } | ||
|
|
||
| @Data | ||
|
|
@@ -146,6 +153,36 @@ public static class User { | |
| private Icon icon; | ||
| } | ||
|
|
||
| @Data | ||
| @Builder | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public static class BooleanField { | ||
| private String type; | ||
|
|
||
| // Checkbox | ||
| private String text; | ||
| private String description; | ||
|
|
||
| // or text-based | ||
| private String trueText; | ||
| private String trueDescription; | ||
| private String falseText; | ||
| private String falseDescription; | ||
| } | ||
|
|
||
| @Data | ||
| @Builder | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public static class EntityRef { | ||
| private String entityUrl; | ||
| private ExternalRef externalRef; | ||
| private String displayType; | ||
| private String title; | ||
| private Icon icon; | ||
| } | ||
|
|
||
| @Data | ||
| @Builder | ||
| @NoArgsConstructor | ||
|
|
@@ -170,8 +207,6 @@ public static class StringField { | |
| public static class Timestamp { | ||
| private String label; | ||
| private Integer value; | ||
| private String link; | ||
| private Icon icon; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These properties weren't valid for this field type |
||
| private String type; | ||
| private Edit edit; | ||
| } | ||
|
|
@@ -220,6 +255,9 @@ public static class CustomField { | |
| private Edit edit; | ||
| private String itemType; | ||
| private User user; | ||
| private EntityRef entityRef; | ||
| @SerializedName("boolean") | ||
| private BooleanField booleanField; | ||
| } | ||
|
|
||
| @Data | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗳️ praise: Nice improvements to these tests once again!