Fix for UnsupportedOperationException in user_change event#407
Merged
seratch merged 1 commit intoslackapi:masterfrom Mar 19, 2020
Merged
Fix for UnsupportedOperationException in user_change event#407seratch merged 1 commit intoslackapi:masterfrom
seratch merged 1 commit intoslackapi:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
============================================
- Coverage 83.91% 83.88% -0.04%
- Complexity 2367 2368 +1
============================================
Files 249 249
Lines 6368 6372 +4
Branches 577 578 +1
============================================
+ Hits 5344 5345 +1
- Misses 670 674 +4
+ Partials 354 353 -1
Continue to review full report at Codecov.
|
seratch
approved these changes
Mar 19, 2020
Contributor
seratch
left a comment
There was a problem hiding this comment.
This fix looks great to me. Thank you very much for your contribution!
seratch
added a commit
that referenced
this pull request
Mar 19, 2020
* [bolt] Fix IgnoringSelfEvents to work with all events #407 - thanks @gaurav2493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When user_change event is sent, the code breaks with the following exception
This happens because code expects
userto contain string but it contained JSON objectfixes #406