Fix #415 attachments payload's validity issue#416
Merged
seratch merged 1 commit intoslackapi:masterfrom Apr 2, 2020
Merged
Conversation
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
============================================
- Coverage 83.92% 83.86% -0.07%
+ Complexity 2368 2367 -1
============================================
Files 249 249
Lines 6372 6372
Branches 578 578
============================================
- Hits 5348 5344 -4
- Misses 670 674 +4
Partials 354 354
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #415 where posting a message with attachments gets an error response from the server-side saying the attachments are invalid.
{ "ok": false, "error": "invalid_attachments", "response_metadata": { "messages": [ "[ERROR] invalid_keys" ] } }The reason of the error is that an attachment payload this library generates contains empty arrays for
fields,mrkdwnIn, andactionsby default. This pull request removes those default values from an attachment initialization.Requirements (place an
xin each[ ])