Skip to content

Improve the "Under the Hood" parts in docs - thanks to feedback at #458#461

Merged
seratch merged 1 commit intoslackapi:masterfrom
seratch:under-the-hood-improvements
May 20, 2020
Merged

Improve the "Under the Hood" parts in docs - thanks to feedback at #458#461
seratch merged 1 commit intoslackapi:masterfrom
seratch:under-the-hood-improvements

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented May 20, 2020

Summary

This pull request replaces some of the pseudo-code in the "Under the Hood" documents. Refer to #458 to know the context.

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label May 20, 2020
@seratch seratch added this to the 1.0.x milestone May 20, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2020

Codecov Report

Merging #461 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #461      +/-   ##
============================================
+ Coverage     83.59%   83.65%   +0.06%     
- Complexity     2386     2387       +1     
============================================
  Files           250      250              
  Lines          6442     6442              
  Branches        590      590              
============================================
+ Hits           5385     5389       +4     
+ Misses          694      690       -4     
  Partials        363      363              
Impacted Files Coverage Δ Complexity Δ
...pi/methods/metrics/impl/RedisMetricsDatastore.java 89.50% <0.00%> (+2.46%) 38.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35cd73...3203c40. Read the comment docs.

@seratch seratch merged commit d8a1eaf into slackapi:master May 20, 2020
@seratch seratch deleted the under-the-hood-improvements branch May 20, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant