Improve the "Under the Hood" parts in docs - thanks to feedback at #458#461
Merged
seratch merged 1 commit intoslackapi:masterfrom May 20, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
============================================
+ Coverage 83.59% 83.65% +0.06%
- Complexity 2386 2387 +1
============================================
Files 250 250
Lines 6442 6442
Branches 590 590
============================================
+ Hits 5385 5389 +4
+ Misses 694 690 -4
Partials 363 363
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request replaces some of the pseudo-code in the "Under the Hood" documents. Refer to #458 to know the context.
Requirements (place an
xin each[ ])