cli-test(fix): wait for cli run start trace instead of activity output

Author: zimeg

packages/cli-test/src/cli/commands/platform.spec.ts

@@ -3,6 +3,7 @@ import assert from 'node:assert';
 import sinon from 'sinon';
 
 import type { ShellProcess } from '../../types/shell';
+import { SlackTracerId } from '../../utils/constants';
 import { mockProcess } from '../../utils/test';
 import { shell } from '../shell';
 import platform from './platform';
@@ -86,6 +87,12 @@ describe('platform commands', () => {
         sinon.match.string,
         sinon.match.array.contains(['run', '--cleanup', '--hide-triggers']),
       );
+      sandbox.assert.calledWith(
+        waitForOutputSpy,
+        SlackTracerId.SLACK_TRACE_PLATFORM_RUN_START,
+        sinon.match.object,
+        sinon.match.object,
+      );
     });
     it('should invoke `run` without --hide-triggers if hideTriggers=false', async () => {
       await platform.runStart({ appPath: '/some/path', hideTriggers: false });
@@ -119,6 +126,12 @@ describe('platform commands', () => {
       sandbox.stub(shell, 'kill').resolves();
       await platform.runStop({ proc: fakeProcess, waitForShutdown: true });
       assert.ok(true);
+      sandbox.assert.calledWith(
+        waitForOutputSpy,
+        SlackTracerId.SLACK_TRACE_PLATFORM_RUN_STOP,
+        sinon.match.object,
+        sinon.match.object,
+      );
     });
   });
 });

packages/cli-test/src/cli/commands/platform.ts

@@ -120,7 +120,7 @@ export const runStart = async function runStart(
     '--hide-triggers': typeof args.hideTriggers !== 'undefined' ? args.hideTriggers : true,
     '--org-workspace-grant': args.orgWorkspaceGrantFlag,
   });
-  const proc = await cmd.execAsyncUntilOutputPresent('Connected, awaiting events', {
+  const proc = await cmd.execAsyncUntilOutputPresent(SlackTracerId.SLACK_TRACE_PLATFORM_RUN_START, {
     cwd: args.appPath,
     timeout: args.timeout,
   });