chore: lint

zimeg · zimeg · commit 72a5125895d5 · 2026-03-02T23:30:40.000-08:00
diff --git a/packages/cli-test/src/cli/cli-process.test.ts b/packages/cli-test/src/cli/cli-process.test.ts
@@ -1,5 +1,5 @@
 import assert from 'node:assert/strict';
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/app.test.ts b/packages/cli-test/src/cli/commands/app.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/auth.test.ts b/packages/cli-test/src/cli/commands/auth.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/collaborator.test.ts b/packages/cli-test/src/cli/commands/collaborator.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/create.test.ts b/packages/cli-test/src/cli/commands/create.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/datastore.test.ts b/packages/cli-test/src/cli/commands/datastore.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/env.test.ts b/packages/cli-test/src/cli/commands/env.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/external-auth.test.ts b/packages/cli-test/src/cli/commands/external-auth.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/function.test.ts b/packages/cli-test/src/cli/commands/function.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/manifest.test.ts b/packages/cli-test/src/cli/commands/manifest.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/platform.test.ts b/packages/cli-test/src/cli/commands/platform.test.ts
@@ -1,5 +1,5 @@
 import assert from 'node:assert/strict';
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/trigger.test.ts b/packages/cli-test/src/cli/commands/trigger.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/commands/version.test.ts b/packages/cli-test/src/cli/commands/version.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/index.test.ts b/packages/cli-test/src/cli/index.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/cli/shell.test.ts b/packages/cli-test/src/cli/shell.test.ts
@@ -1,7 +1,6 @@
-import child from 'node:child_process';
-
 import assert from 'node:assert/strict';
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import child from 'node:child_process';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/cli-test/src/index.test.ts b/packages/cli-test/src/index.test.ts
@@ -1,5 +1,5 @@
 import assert from 'node:assert/strict';
-import { describe, it, afterEach } from 'node:test';
+import { afterEach, describe, it } from 'node:test';
 
 import sinon from 'sinon';
 
diff --git a/packages/oauth/src/callback-options.test.ts b/packages/oauth/src/callback-options.test.ts
@@ -1,6 +1,5 @@
-import { IncomingMessage, ServerResponse } from 'node:http';
-
 import assert from 'node:assert/strict';
+import { IncomingMessage, ServerResponse } from 'node:http';
 import { describe, it } from 'node:test';
 import sinon from 'sinon';
 
diff --git a/packages/oauth/src/install-path-options.test.ts b/packages/oauth/src/install-path-options.test.ts
@@ -1,6 +1,5 @@
-import { IncomingMessage, ServerResponse } from 'node:http';
-
 import assert from 'node:assert/strict';
+import { IncomingMessage, ServerResponse } from 'node:http';
 import { describe, it } from 'node:test';
 import sinon from 'sinon';
 
diff --git a/packages/oauth/src/install-provider.test.ts b/packages/oauth/src/install-provider.test.ts
@@ -1,23 +1,16 @@
-import url from 'node:url';
 import assert from 'node:assert/strict';
-import { describe, it, beforeEach } from 'node:test';
+import { beforeEach, describe, it } from 'node:test';
+import url from 'node:url';
+import type { OAuthV2AccessArguments, OauthV2AccessResponse, WebClientOptions } from '@slack/web-api';
 import rewiremock from 'rewiremock';
 import sinon from 'sinon';
-
-import type { OAuthV2AccessArguments, OauthV2AccessResponse, WebClientOptions } from '@slack/web-api';
-import type {
-  CallbackOptions,
-  Installation,
-  InstallationStore,
-  InstallPathOptions,
-  StateStore,
-} from './index';
 import {
   type AuthorizationError,
   ErrorCode,
   type GenerateInstallUrlError,
   type InstallerInitializationError,
 } from './errors';
+import type { CallbackOptions, Installation, InstallationStore, InstallPathOptions, StateStore } from './index';
 import { type Logger, LogLevel } from './logger';
 
 // Stub WebClient api calls that the OAuth package makes
@@ -52,8 +45,6 @@ rewiremock(() => require('@slack/web-api')).with({
 rewiremock.enable();
 
 // Use require() so rewiremock can intercept @slack/web-api dependency
-// biome-ignore lint/style/noVar: need var for hoisting compatibility
-// biome-ignore lint/correctness/noUndeclaredVariables: require is available
 var { InstallProvider } = require('./index') as typeof import('./index');
 
 rewiremock.disable();
@@ -384,7 +375,10 @@ describe('InstallProvider', async () => {
         headers.Location,
         'https://slack.com/oauth/v2/authorize?scope=channels%3Aread&state=fakeState&client_id=MY_ID&redirect_uri=https%3A%2F%2Fmysite.com%2Fslack%2Fredirect&team=T12345&user_scope=chat%3Awrite%3Auser',
       );
-      assert.strictEqual(headers['Set-Cookie'], 'slack-app-oauth-state=fakeState; Secure; HttpOnly; Path=/; Max-Age=600');
+      assert.strictEqual(
+        headers['Set-Cookie'],
+        'slack-app-oauth-state=fakeState; Secure; HttpOnly; Path=/; Max-Age=600',
+      );
     });
     it('should redirect installers with data set by InstallPathOptions.beforeRedirection()', async () => {
       const installer = new InstallProvider({
@@ -424,7 +418,10 @@ describe('InstallProvider', async () => {
         'https://slack.com/oauth/v2/authorize?scope=channels%3Aread&state=fakeState&client_id=MY_ID&redirect_uri=https%3A%2F%2Fmysite.com%2Fslack%2Fredirect&team=T12345&user_scope=chat%3Awrite%3Auser',
       );
       assert.strictEqual(headers['Set-Cookie'][0], 'additional-cookie=external-service-user-id; Secure; HttpOnly;');
-      assert.strictEqual(headers['Set-Cookie'][1], 'slack-app-oauth-state=fakeState; Secure; HttpOnly; Path=/; Max-Age=600');
+      assert.strictEqual(
+        headers['Set-Cookie'][1],
+        'slack-app-oauth-state=fakeState; Secure; HttpOnly; Path=/; Max-Age=600',
+      );
     });
   });
 
diff --git a/packages/oauth/src/installation-stores/file-store.test.ts b/packages/oauth/src/installation-stores/file-store.test.ts
@@ -134,7 +134,10 @@ describe('FileInstallationStore', async () => {
     await installationStore.storeInstallation(storedInstallation);
 
     assert.strictEqual(fsWriteFileSync.calledWith(sinon.match(`${fakeInstallDir}/app-`), installationJSON), true);
-    assert.strictEqual(fsWriteFileSync.calledWith(sinon.match(`${fakeInstallDir}/user-${user.id}-`), installationJSON), true);
+    assert.strictEqual(
+      fsWriteFileSync.calledWith(sinon.match(`${fakeInstallDir}/user-${user.id}-`), installationJSON),
+      true,
+    );
 
     // 1 store = 4 files = 2 latest + 2 timestamps
     assert.strictEqual(fsWriteFileSync.callCount, 4);
@@ -165,7 +168,10 @@ describe('FileInstallationStore', async () => {
       });
       assert.fail(`An exception should be thrown ${JSON.stringify(res)}`);
     } catch (e: any) {
-      assert.strictEqual(e.message, 'No installation data found (enterprise_id: E999, team_id: T111, user_id: undefined)');
+      assert.strictEqual(
+        e.message,
+        'No installation data found (enterprise_id: E999, team_id: T111, user_id: undefined)',
+      );
     }
   });
 
diff --git a/packages/oauth/src/state-stores/spec-utils.ts b/packages/oauth/src/state-stores/spec-utils.ts
@@ -67,7 +67,11 @@ export class StateStoreChaiTestRunner {
             assert.fail('Exception should be thrown');
             // biome-ignore lint/suspicious/noExplicitAny: errors can be anything
           } catch (e: any) {
-            assert.strictEqual(e.code, 'slack_oauth_invalid_state', `${state} ${JSON.stringify(expectedlyReturnedResult)}`);
+            assert.strictEqual(
+              e.code,
+              'slack_oauth_invalid_state',
+              `${state} ${JSON.stringify(expectedlyReturnedResult)}`,
+            );
           }
         });
       }
diff --git a/packages/socket-mode/src/SlackWebSocket.test.ts b/packages/socket-mode/src/SlackWebSocket.test.ts
@@ -1,6 +1,6 @@
-import { ConsoleLogger } from '@slack/logger';
 import assert from 'node:assert/strict';
 import { afterEach, beforeEach, describe, it } from 'node:test';
+import { ConsoleLogger } from '@slack/logger';
 import EventEmitter from 'eventemitter3';
 import proxyquire from 'proxyquire';
 import sinon from 'sinon';
diff --git a/packages/socket-mode/src/SocketModeClient.test.ts b/packages/socket-mode/src/SocketModeClient.test.ts
@@ -1,6 +1,6 @@
-import { ConsoleLogger } from '@slack/logger';
 import assert from 'node:assert/strict';
 import { afterEach, beforeEach, describe, it } from 'node:test';
+import { ConsoleLogger } from '@slack/logger';
 import sinon from 'sinon';
 
 import logModule from './logger';
diff --git a/packages/socket-mode/test/integration.test.js b/packages/socket-mode/test/integration.test.js
@@ -176,7 +176,9 @@ describe('Integration tests with a WebSocket server', { timeout: 30000 }, () =>
       // with `undefined` after disconnect(). node:test detects these as unhandled
       // rejections (mocha did not). Mock process.emit to swallow them during cleanup.
       const originalEmit = process.emit.bind(process);
-      t.after(() => { process.emit = originalEmit; });
+      t.after(() => {
+        process.emit = originalEmit;
+      });
       // override socket mode client instance with lower client ping timeout, which controls reconnection rate
       client = new SocketModeClient({
         appToken: 'whatever',
diff --git a/packages/web-api/src/WebClient.test.ts b/packages/web-api/src/WebClient.test.ts
@@ -1,6 +1,6 @@
-import fs from 'node:fs';
 import assert from 'node:assert/strict';
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import fs from 'node:fs';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 import type { ContextActionsBlock } from '@slack/types';
 import axios, { type InternalAxiosRequestConfig } from 'axios';
 import nock, { type ReplyHeaders } from 'nock';
@@ -1177,7 +1177,10 @@ describe('WebClient', () => {
       assert.fail('expected error to be thrown');
     } catch (err) {
       assert.ok(err instanceof Error);
-      assert.ok((err as Error).message.includes('retry-after header: notanumber'), 'Raw retry-after header value included in error');
+      assert.ok(
+        (err as Error).message.includes('retry-after header: notanumber'),
+        'Raw retry-after header value included in error',
+      );
       scope.done();
     }
   });
@@ -1965,7 +1968,7 @@ describe('WebClient', () => {
       try {
         await client.apiCall('conversations/list');
       } catch (error) {
-        assert.ok(Object.prototype.hasOwnProperty.call(error, 'original'));
+        assert.ok(Object.hasOwn(error, 'original'));
         scope.done();
       }
     });
@@ -1979,7 +1982,7 @@ describe('WebClient', () => {
       try {
         await client.apiCall('conversations/list');
       } catch (error) {
-        assert.ok(Object.prototype.hasOwnProperty.call(error, 'original'));
+        assert.ok(Object.hasOwn(error, 'original'));
         scope.done();
       }
     });
@@ -1993,7 +1996,7 @@ describe('WebClient', () => {
       try {
         await client.apiCall('conversations/list');
       } catch (error) {
-        assert.ok(!Object.prototype.hasOwnProperty.call(error, 'original'));
+        assert.ok(!Object.hasOwn(error, 'original'));
         scope.done();
       }
     });
diff --git a/packages/web-api/src/file-upload.test.ts b/packages/web-api/src/file-upload.test.ts
@@ -1,6 +1,6 @@
-import { createReadStream, statSync, unlinkSync, writeFileSync } from 'node:fs';
 import assert from 'node:assert/strict';
-import { describe, it, beforeEach, afterEach } from 'node:test';
+import { createReadStream, statSync, unlinkSync, writeFileSync } from 'node:fs';
+import { afterEach, beforeEach, describe, it } from 'node:test';
 import sinon from 'sinon';
 import { ErrorCode } from './errors';
 import {
@@ -193,7 +193,10 @@ describe('file-upload', () => {
         const res = await getFileData(invalidFileUpload2);
         assert.fail(res.toString());
       } catch (err) {
-        assert.strictEqual((err as Record<string, unknown>).message, 'file must be a valid string path, buffer or Readable');
+        assert.strictEqual(
+          (err as Record<string, unknown>).message,
+          'file must be a valid string path, buffer or Readable',
+        );
         assert.strictEqual((err as Record<string, unknown>).code, ErrorCode.FileUploadInvalidArgumentsError);
       }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { describe, it, beforeEach, afterEach } from 'node:test';`
	`1`	`+import { afterEach, beforeEach, describe, it } from 'node:test';`
`2`	`2`
`3`	`3`	`import sinon from 'sinon';`
`4`	`4`