style: lint

Author: zimeg

packages/oauth/src/install-provider.test.ts

@@ -204,6 +204,7 @@ describe('InstallProvider', async () => {
     it('should build a default installer given a clientID, client secret and stateSecret', async () => {
       const installer = new InstallProvider({ clientId, clientSecret, stateSecret, logger: noopLogger });
       assert.ok(installer instanceof InstallProvider);
+      // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
       assert.strictEqual((installer as any).authVersion, 'v2');
     });
 
@@ -216,7 +217,9 @@ describe('InstallProvider', async () => {
         clientOptions: webClientOptions,
       });
       assert.ok(installer instanceof InstallProvider);
+      // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
       assert.strictEqual((installer as any).authVersion, 'v2');
+      // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
       assert.strictEqual((installer as any).clientOptions.timeout, webClientOptions.timeout);
     });
 
@@ -251,6 +254,7 @@ describe('InstallProvider', async () => {
         logger: noopLogger,
       });
       assert.ok(installer instanceof InstallProvider);
+      // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
       assert.strictEqual((installer as any).authVersion, 'v2');
     });
 
@@ -263,6 +267,7 @@ describe('InstallProvider', async () => {
         logger: noopLogger,
       });
       assert.ok(installer instanceof InstallProvider);
+      // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
       assert.strictEqual((installer as any).authVersion, 'v1');
     });
 

packages/oauth/src/installation-stores/file-store.test.ts

@@ -4,6 +4,7 @@ import os from 'node:os';
 import { afterEach, beforeEach, describe, it } from 'node:test';
 import sinon from 'sinon';
 
+import type { InstallationQuery } from '../index';
 import { InstallProvider } from '../index';
 import { FileInstallationStore } from './index';
 
@@ -79,11 +80,11 @@ describe('FileInstallationStore', async () => {
   beforeEach(() => {
     // Note that these sinon stubs affect the `os` package behaviors
     // in the tests in this file
-    fsMakeDirSync = sinon.stub(fs, 'mkdirSync').returns({} as any);
-    fsWriteFileSync = sinon.stub(fs, 'writeFileSync').returns(undefined as any);
+    fsMakeDirSync = (sinon.stub(fs, 'mkdirSync') as sinon.SinonStub).returns(undefined);
+    fsWriteFileSync = (sinon.stub(fs, 'writeFileSync') as sinon.SinonStub).returns(undefined);
     fsReadFileSync = sinon.stub(fs, 'readFileSync').returns(Buffer.from(JSON.stringify(storedInstallation)));
-    fsUnlinkSync = sinon.stub(fs, 'unlinkSync').returns(undefined as any);
-    fsReaddirSync = sinon.stub(fs, 'readdirSync').returns(['app-latest', 'user-userId-latest'] as any);
+    fsUnlinkSync = (sinon.stub(fs, 'unlinkSync') as sinon.SinonStub).returns(undefined);
+    fsReaddirSync = (sinon.stub(fs, 'readdirSync') as sinon.SinonStub).returns(['app-latest', 'user-userId-latest']);
   });
 
   afterEach(() => {
@@ -117,7 +118,8 @@ describe('FileInstallationStore', async () => {
     try {
       await installationStore.storeInstallation(storedInstallation);
       assert.fail('An exception should be thrown');
-    } catch (e: any) {
+    } catch (e: unknown) {
+      assert.ok(e instanceof Error);
       assert.strictEqual(
         e.message,
         'Failed to save installation to FileInstallationStore (error: Error: The original error message)',
@@ -167,7 +169,8 @@ describe('FileInstallationStore', async () => {
         teamId: 'T111',
       });
       assert.fail(`An exception should be thrown ${JSON.stringify(res)}`);
-    } catch (e: any) {
+    } catch (e: unknown) {
+      assert.ok(e instanceof Error);
       assert.strictEqual(
         e.message,
         'No installation data found (enterprise_id: E999, team_id: T111, user_id: undefined)',
@@ -232,13 +235,13 @@ describe('FileInstallationStore', async () => {
       },
     };
     const installationStore = {
-      fetchInstallation: (_: any) => {
+      fetchInstallation: (_: InstallationQuery<boolean>) => {
         return new Promise((resolve) => {
           resolve(storedInstallation);
         });
       },
       storeInstallation: () => {},
-      deleteInstallation: (_: any) => {},
+      deleteInstallation: (_: InstallationQuery<boolean>) => {},
     };
     const installer = new InstallProvider({ clientId, clientSecret, stateSecret, installationStore });
     const authorizeResult = await installer.authorize({ teamId: 'T111' });
@@ -270,13 +273,13 @@ describe('FileInstallationStore', async () => {
       user: null,
     };
     const installationStore = {
-      fetchInstallation: (_: any) => {
+      fetchInstallation: (_: InstallationQuery<boolean>) => {
         return new Promise((resolve) => {
           resolve(storedInstallation);
         });
       },
       storeInstallation: () => {},
-      deleteInstallation: (_: any) => {},
+      deleteInstallation: (_: InstallationQuery<boolean>) => {},
     };
     const installer = new InstallProvider({ clientId, clientSecret, stateSecret, installationStore });
     const authorizeResult = await installer.authorize({ teamId: 'T111' });

packages/webhook/src/IncomingWebhook.test.ts

@@ -2,6 +2,7 @@ import assert from 'node:assert/strict';
 import { afterEach, beforeEach, describe, it } from 'node:test';
 import nock from 'nock';
 
+import type { CodedError } from './errors';
 import { ErrorCode } from './errors';
 import { IncomingWebhook } from './IncomingWebhook';
 
@@ -20,12 +21,14 @@ describe('IncomingWebhook', () => {
 
     it('should create a default webhook with a default timeout', () => {
       const webhook = new IncomingWebhook(url);
+      // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
       assert.strictEqual((webhook as any).defaults.timeout, 0);
     });
 
     it('should create an axios instance that has the timeout passed by the user', () => {
       const givenTimeout = 100;
       const webhook = new IncomingWebhook(url, { timeout: givenTimeout });
+      // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
       assert.strictEqual((webhook as any).axios.defaults.timeout, givenTimeout);
     });
   });
@@ -94,7 +97,7 @@ describe('IncomingWebhook', () => {
           assert.fail('expected rejection');
         } catch (error) {
           assert.ok(error instanceof Error);
-          assert.strictEqual((error as any).code, ErrorCode.RequestError);
+          assert.strictEqual((error as CodedError).code, ErrorCode.RequestError);
         }
       });
     });
@@ -108,6 +111,7 @@ describe('IncomingWebhook', () => {
           await webhook.send({ channel: 'different' });
           assert.fail('expected rejection');
         } catch (_err) {
+          // biome-ignore lint/suspicious/noExplicitAny: accessing private property for test assertion
           assert.strictEqual((webhook as any).defaults.channel, defaultParams.channel);
         }
       });