tighten up the PR

Author: WilliamBergamin

packages/oauth/src/state-stores/file-state-store.spec.ts

@@ -1,10 +1,6 @@
-// import fs from 'node:fs';
 import os from 'node:os';
-// import { assert, expect } from 'chai';
-// import sinon from 'sinon';
 
 import { FileStateStore } from './file-state-store';
-// import type { StateStore } from './interface';
 import { StateStoreChaiTestRunner } from './spec-utils';
 
 const testRunner = new StateStoreChaiTestRunner({
@@ -13,33 +9,3 @@ const testRunner = new StateStoreChaiTestRunner({
   }),
 });
 testRunner.enableTests('FileStateStore');
-
-// describe('FileStateStore specifics', () => {
-//   const stateStore: StateStore = new FileStateStore({
-//     baseDir: os.tmpdir(),
-//   });
-//   const installUrlOptions = { scopes: ['channels:read'] };
-
-//   it('should close all files after writing them', async () => {
-//     const writeFileSyncStub = sinon.stub(fs, 'writeFileSync').throws(new Error('mock_write_error'));
-
-//     try {
-//       await stateStore.generateStateParam(installUrlOptions, new Date());
-//       assert.fail('Exception should be thrown');
-//       // biome-ignore lint/suspicious/noExplicitAny: errors can be anything
-//     } catch (e: any) {
-//       assert.equal(e.message, 'mock_write_error');
-//     }
-
-//     assert(writeFileSyncStub.calledOnce, 'writeFileSync should be called once');
-//     const fd = writeFileSyncStub.getCall(0).args[0] as number;
-
-//     expect(
-//       () => fs.fstatSync(fd),
-//       'The file must be closed, we expect fstatSync to throw an error when the file is closed',
-//     ).to.throw('EBADF: bad file descriptor, fstat');
-
-//     // Restore original function
-//     writeFileSyncStub.restore();
-//   });
-// });

packages/oauth/src/state-stores/spec-utils.ts

@@ -59,8 +59,8 @@ export class StateStoreChaiTestRunner {
           }
           const state = await stateStore.generateStateParam(installUrlOptions, new Date());
 
-          // NOTE: wait 1 second to make sure IO operations completed
-          await new Promise((resolve, _) => setTimeout(resolve, 1000));
+          // NOTE: wait 0.5 second to ensure IO operations completed
+          await new Promise((resolve, _) => setTimeout(resolve, 500));
 
           const result = await stateStore.verifyStateParam(new Date(), state);
           assert.exists(result);