Skip to content

Commit 98dbd4e

Browse files
authored
build: use a shared tsconfig for workspace packages (#2532)
1 parent 8ce4770 commit 98dbd4e

File tree

22 files changed

+73
-290
lines changed

22 files changed

+73
-290
lines changed

.claude/settings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"permissions": {
33
"allow": [
4+
"Bash(cat:*)",
45
"Bash(echo:*)",
56
"Bash(gh issue view:*)",
67
"Bash(gh label list:*)",

.github/dependabot.yml

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,6 @@ updates:
1313
patterns:
1414
- "@types/mocha"
1515
- "mocha"
16-
ignore:
17-
- dependency-name: "@types/node"
18-
versions:
19-
- "19.x"
20-
- "20.x"
21-
- "21.x"
22-
- "22.x"
23-
- "23.x"
24-
- "24.x"
25-
- "25.x"
2616
labels:
2717
- "dependencies"
2818
- "javascript"
@@ -48,16 +38,6 @@ updates:
4838
patterns:
4939
- "@types/mocha"
5040
- "mocha"
51-
ignore:
52-
- dependency-name: "@types/node"
53-
versions:
54-
- "19.x"
55-
- "20.x"
56-
- "21.x"
57-
- "22.x"
58-
- "23.x"
59-
- "24.x"
60-
- "25.x"
6141
labels:
6242
- "dependencies"
6343
- "javascript"
@@ -178,16 +158,6 @@ updates:
178158

179159
- package-ecosystem: "npm"
180160
directory: "/packages/types"
181-
ignore:
182-
- dependency-name: "@types/node"
183-
versions:
184-
- "19.x"
185-
- "20.x"
186-
- "21.x"
187-
- "22.x"
188-
- "23.x"
189-
- "24.x"
190-
- "25.x"
191161
labels:
192162
- "dependencies"
193163
- "javascript"
@@ -289,6 +259,16 @@ updates:
289259

290260
- package-ecosystem: "npm"
291261
directory: "/"
262+
ignore:
263+
- dependency-name: "@types/node"
264+
versions:
265+
- "19.x"
266+
- "20.x"
267+
- "21.x"
268+
- "22.x"
269+
- "23.x"
270+
- "24.x"
271+
- "25.x"
292272
labels:
293273
- "dependencies"
294274
- "javascript"

package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626
},
2727
"devDependencies": {
2828
"@biomejs/biome": "^2.0.5",
29-
"@changesets/cli": "^2.29.8"
29+
"@changesets/cli": "^2.29.8",
30+
"@types/node": "^18.19.130",
31+
"shx": "^0.4.0",
32+
"tsx": "^4.20.6",
33+
"typescript": "5.9.3"
3034
}
3135
}

packages/cli-hooks/jsconfig.json

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,9 @@
11
{
2+
"$schema": "https://json.schemastore.org/jsconfig",
3+
"extends": "../../tsconfig.base.json",
24
"compilerOptions": {
35
"module": "es2022",
4-
"moduleResolution": "node",
5-
"esModuleInterop": true,
6-
"checkJs": true,
7-
8-
"strict": true,
9-
"noUnusedLocals": true,
10-
"noUnusedParameters": true,
11-
"noImplicitReturns": true,
12-
"noFallthroughCasesInSwitch": true,
13-
14-
"baseUrl": ".",
15-
"paths": {
16-
"*": ["./types/*"]
17-
}
6+
"checkJs": true
187
},
19-
"include": ["src/**/*"],
20-
"jsdoc": {
21-
"out": "support/jsdoc",
22-
"access": "public"
23-
}
8+
"include": ["src/**/*"]
249
}

packages/cli-hooks/package.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,8 @@
5454
},
5555
"devDependencies": {
5656
"@types/minimist": "^1.2.5",
57-
"@types/node": "^18.19.130",
5857
"@types/semver": "^7.5.6",
5958
"@types/sinon": "^21.0.0",
60-
"shx": "^0.4.0",
61-
"sinon": "^21.0.0",
62-
"typescript": "5.9.3"
59+
"sinon": "^21.0.0"
6360
}
6461
}

packages/cli-test/package.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,10 @@
4141
"winston": "^3.8.2"
4242
},
4343
"devDependencies": {
44-
"@tsconfig/recommended": "^1.0.6",
45-
"@types/node": "^18.19.130",
4644
"@types/sinon": "^21.0.0",
4745
"cross-env": "^10.0.0",
48-
"shx": "^0.4.0",
4946
"sinon": "^21.0.0",
50-
"tsx": "^4.20.6",
5147
"typedoc": "^0.28.7",
52-
"typedoc-plugin-markdown": "^4.7.1",
53-
"typescript": "5.9.3"
48+
"typedoc-plugin-markdown": "^4.7.1"
5449
}
5550
}

packages/cli-test/tsconfig.json

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,6 @@
11
{
22
"$schema": "https://json.schemastore.org/tsconfig",
3-
"compilerOptions": {
4-
"declaration": true,
5-
"declarationMap": true,
6-
"esModuleInterop": true,
7-
"noFallthroughCasesInSwitch": true,
8-
"noImplicitReturns": true,
9-
"noUnusedLocals": true,
10-
"noUnusedParameters": true,
11-
"outDir": "dist",
12-
"skipLibCheck": true,
13-
"sourceMap": true
14-
},
15-
"extends": "@tsconfig/recommended/tsconfig.json",
3+
"extends": "../../tsconfig.base.json",
164
"include": ["src/**/*"],
17-
"jsdoc": {
18-
"out": "support/jsdoc",
19-
"access": "public"
20-
},
215
"exclude": ["src/**/*.test.*"]
226
}

packages/logger/package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,7 @@
4141
"@types/node": ">=18"
4242
},
4343
"devDependencies": {
44-
"@types/node": "^18.19.130",
45-
"shx": "^0.4.0",
46-
"tsx": "^4.20.6",
4744
"typedoc": "^0.28.7",
48-
"typedoc-plugin-markdown": "^4.7.1",
49-
"typescript": "^5.9.3"
45+
"typedoc-plugin-markdown": "^4.7.1"
5046
}
5147
}

packages/logger/tsconfig.json

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,6 @@
11
{
22
"$schema": "https://json.schemastore.org/tsconfig",
3-
"compilerOptions": {
4-
"target": "es2017",
5-
"module": "commonjs",
6-
"declaration": true,
7-
"declarationMap": true,
8-
"sourceMap": true,
9-
"outDir": "dist",
10-
"skipLibCheck": true,
11-
"strict": true,
12-
"noUnusedLocals": true,
13-
"noUnusedParameters": true,
14-
"noImplicitReturns": true,
15-
"noFallthroughCasesInSwitch": true,
16-
"moduleResolution": "node",
17-
"baseUrl": ".",
18-
"paths": {
19-
"*": ["./types/*"]
20-
},
21-
"esModuleInterop": true
22-
// Not using this setting because it's only used to require the package.json file, and that would change the
23-
// structure of the files in the dist directory because package.json is not located inside src. It would be nice
24-
// to use import instead of require(), but it's not worth the tradeoff of restructuring the build (for now).
25-
// "resolveJsonModule": true,
26-
},
3+
"extends": "../../tsconfig.base.json",
274
"include": ["src/**/*"],
28-
"exclude": ["src/**/*.test.*"],
29-
"jsdoc": {
30-
"out": "support/jsdoc",
31-
"access": "public"
32-
}
5+
"exclude": ["src/**/*.test.*"]
336
}

packages/oauth/package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,10 @@
4848
"jsonwebtoken": "^9"
4949
},
5050
"devDependencies": {
51-
"@types/node": "^18.19.130",
5251
"@types/sinon": "^21",
5352
"rewiremock": "^3",
54-
"shx": "^0.4.0",
5553
"sinon": "^21",
56-
"tsx": "^4.20.6",
5754
"typedoc": "^0.28.7",
58-
"typedoc-plugin-markdown": "^4.7.0",
59-
"typescript": "5.9.3"
55+
"typedoc-plugin-markdown": "^4.7.0"
6056
}
6157
}

0 commit comments

Comments
 (0)