Skip to content

Commit b8d922f

Browse files
authored
ci: add support for node 24 version (#2534)
1 parent 9b23414 commit b8d922f

File tree

5 files changed

+25
-9
lines changed

5 files changed

+25
-9
lines changed

.changeset/plenty-times-rhyme.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
"@slack/socket-mode": patch
3+
"@slack/cli-hooks": patch
4+
"@slack/cli-test": patch
5+
"@slack/web-api": patch
6+
"@slack/webhook": patch
7+
"@slack/logger": patch
8+
"@slack/oauth": patch
9+
"@slack/types": patch
10+
---
11+
12+
build: add support for node 24

.changeset/vast-drinks-raise.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@slack/logger": patch
3+
---
4+
5+
build: remove @types/node from required dependencies

.github/workflows/ci-build.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
- "18.x"
2020
- "20.x"
2121
- "22.x"
22+
- "24.x"
2223
runs-on: ${{ matrix.os }}
2324
permissions:
2425
contents: read
@@ -64,16 +65,14 @@ jobs:
6465
- name: Build docs
6566
run: npm run docs
6667
- name: Run tests (Node 18/20)
67-
if: matrix.node-version != '22.x'
68-
shell: bash
68+
if: matrix.node-version != '22.x' && matrix.node-version != '24.x'
6969
# Node 18 lacks --test-reporter; Node 20 has coverage bugs. Use simpler script.
7070
run: npm run test:node18 --workspaces --if-present
71-
- name: Run tests (Node 22)
72-
if: matrix.node-version == '22.x'
73-
shell: bash
71+
- name: Run tests (Node 22+)
72+
if: matrix.node-version == '22.x' || matrix.node-version == '24.x'
7473
run: npm test
7574
- name: Upload code coverage
76-
if: matrix.node-version == '22.x' && matrix.os == 'ubuntu-latest'
75+
if: matrix.node-version == '24.x' && matrix.os == 'ubuntu-latest'
7776
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
7877
with:
7978
fail_ci_if_error: true

AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ npm run build --workspace=@slack/socket-mode
7878
2. **Request types ARE manually maintained**`packages/web-api/src/types/request/` is hand-written code; edit these responsibly.
7979
3. **Build packages in dependency order** — see the dependency graph above.
8080
4. **Use Biome**, not ESLint or Prettier — config is in `biome.json` at repo root.
81-
5. **TypeScript 5.9.3**, Node 18+.
81+
5. **TypeScript 5.9.3**, Node 18+ (tested on Node 18, 20, 22, 24).
8282

8383
## Code Conventions
8484

@@ -282,7 +282,7 @@ Entry point for response type generation. It:
282282
- **Unit tests**: `*.test.{ts,js}` files alongside source (e.g., `src/WebClient.test.ts`)
283283
- **Type tests**: tsd (`*.test-d.ts` files in `packages/web-api/test/types/`)
284284
- **Integration tests**: CommonJS, ESM, and TypeScript compatibility checks
285-
- **CI matrix**: Node 18.x, 20.x, 22.x on Ubuntu + Windows (6 jobs total)
285+
- **CI matrix**: Node 18.x, 20.x, 22.x, 24.x on Ubuntu + Windows (8 jobs total)
286286
- **Coverage output**: `lcov.info` at each package root (not in `coverage/` dir)
287287
- **Test results**: `test-results.xml` at each package root (JUnit format)
288288

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ Refer to [the module document page](https://docs.slack.dev/tools/node-slack-sdk/
9494

9595
## Requirements
9696

97-
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
97+
This package supports Node v18 and higher. It's highly recommended to use [the latest LTS version of
9898
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
9999
from that version.
100100

0 commit comments

Comments
 (0)