Update web-api

Author: vegeris

packages/types/src/message-metadata.ts

@@ -27,7 +27,7 @@ export interface MessageMetadataEventPayloadObject {
 }
 
 /**
- * @description Metadata that represents an entity.
+ * @description An array of entities.
  */
 export interface EntitiesMetadata {
   entities: EntityMetadata[];

packages/web-api/src/types/request/chat.ts

@@ -2,7 +2,7 @@ import type { OptionalArgument } from '../helpers';
 
 import type {
   Block, // TODO: these will be combined into one in a new types release
-  EntitiesMetadata,
+  EntityMetadata,
   KnownBlock,
   LinkUnfurls,
   MessageAttachment,
@@ -221,25 +221,31 @@ export interface SourceAndUnfurlID {
 }
 type UnfurlTarget = ChannelAndTS | SourceAndUnfurlID;
 
-type ChatUnfurlEntitiesMetadata = EntitiesMetadata & {
-  /**
-   * @description The unfurl URL for the entity.
-   */
-  app_unfurl_url?: string;
-};
-
-// https://api.slack.com/methods/chat.unfurl
-export type ChatUnfurlArguments = {
+type ChatUnfurlArgumentUnfurls = {
   /**
    * @description Object with keys set to URLs featured in the message, pointing to their unfurl
    * blocks or message attachments.
    */
-  unfurls?: LinkUnfurls;
+  unfurls: LinkUnfurls;
+};
+
+type ChatUnfurlArgumentMetadata = {
   /**
    * @description Array of entities to attach to the message based on URLs featured in the message.
    */
-  metadata?: ChatUnfurlEntitiesMetadata;
-} & UnfurlTarget &
+  metadata: {
+    entities: (EntityMetadata & {
+      /**
+       * @description The unfurl URL for the entity.
+       */
+      app_unfurl_url: string;
+    })[];
+  };
+};
+
+// https://api.slack.com/methods/chat.unfurl
+export type ChatUnfurlArguments = (ChatUnfurlArgumentUnfurls | ChatUnfurlArgumentMetadata) &
+  UnfurlTarget &
   TokenOverridable & {
     /**
      * @description Provide a simply-formatted string to send as an ephemeral message to the user as invitation to

packages/web-api/test/types/methods/chat.test-d.ts

@@ -546,7 +546,7 @@ expectError(
 );
 expectError(
   web.chat.unfurl({
-    channel: 'C1234', // missing unfurls
+    channel: 'C1234', // missing both unfurls and metadata
     ts: '1234.56',
   }),
 );
@@ -600,6 +600,37 @@ expectAssignable<Parameters<typeof web.chat.unfurl>>([
     ts: '1234.56',
   },
 ]);
+expectAssignable<Parameters<typeof web.chat.unfurl>>([
+  {
+    channel: 'C1234',
+    ts: '1234.56',
+    metadata: {
+      entities: [
+        {
+          entity_type: '',
+          entity_payload: {},
+          app_unfurl_url: 'https://google.com',
+        },
+      ],
+    },
+  },
+]);
+expectAssignable<Parameters<typeof web.chat.unfurl>>([
+  {
+    channel: 'C1234',
+    ts: '1234.56',
+    unfurls: {}, // Accepts both unfurl and metadata attachments
+    metadata: {
+      entities: [
+        {
+          entity_type: '',
+          entity_payload: {},
+          app_unfurl_url: 'https://google.com',
+        },
+      ],
+    },
+  },
+]);
 
 // chat.update
 // -- sad path