Skip to content

Commit f430ae8

Browse files
authored
fix(cli-hooks): use correct bolt-js release notes tag format (#2602)
1 parent 7ad18f2 commit f430ae8

3 files changed

Lines changed: 12 additions & 7 deletions

File tree

.changeset/stale-dolls-shave.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@slack/cli-hooks": patch
3+
---
4+
5+
fix: use correct bolt-js release notes tag format

packages/cli-hooks/src/check-update.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ async function fetchLatestPackageVersion(packageName) {
216216
*/
217217
function getReleaseNotesUrl(packageName, latestVersion) {
218218
if (packageName === SLACK_BOLT_SDK) {
219-
return `https://github.com/slackapi/bolt-js/releases/tag/@slack/bolt@${latestVersion}`;
219+
return `https://github.com/slackapi/bolt-js/releases/tag/v${latestVersion}`;
220220
}
221221
if (packageName === SLACK_CLI_HOOKS) {
222222
return `https://github.com/slackapi/node-slack-sdk/releases/tag/@slack/cli-hooks@${latestVersion}`;

packages/cli-hooks/src/check-update.test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import checkForSDKUpdates, {
1818
const packageJSON = {
1919
name: 'Example application',
2020
dependencies: {
21-
'@slack/bolt': '^3.0.0',
21+
'@slack/bolt': '^4.0.0',
2222
},
2323
devDependencies: {
2424
'@slack/cli-hooks': '^0.0.1',
@@ -32,13 +32,13 @@ const packageJSON = {
3232
*/
3333
function mockNPM(command) {
3434
if (command === 'npm info @slack/bolt version --tag latest') {
35-
return '3.1.4';
35+
return '4.7.2';
3636
}
3737
if (command === 'npm info @slack/cli-hooks version --tag latest') {
3838
return '1.0.1';
3939
}
4040
if (command === 'npm list @slack/bolt --depth=0 --json') {
41-
return '{"dependencies":{"@slack/bolt":{"version":"3.0.0"}}}';
41+
return '{"dependencies":{"@slack/bolt":{"version":"4.0.0"}}}';
4242
}
4343
if (command === 'npm list @slack/cli-hooks --depth=0 --json') {
4444
return '{"dependencies":{"@slack/cli-hooks":{"version":"0.0.1"}}}';
@@ -72,13 +72,13 @@ describe('check-update implementation', async () => {
7272
releases: [
7373
{
7474
name: '@slack/bolt',
75-
current: '3.0.0',
76-
latest: '3.1.4',
75+
current: '4.0.0',
76+
latest: '4.7.2',
7777
error: undefined,
7878
update: true,
7979
message: undefined,
8080
breaking: false,
81-
url: 'https://github.com/slackapi/bolt-js/releases/tag/@slack/bolt@3.1.4',
81+
url: 'https://github.com/slackapi/bolt-js/releases/tag/v4.7.2',
8282
},
8383
{
8484
name: '@slack/cli-hooks',

0 commit comments

Comments
 (0)