Skip to content

build: use a shared tsconfig for workspace packages #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 11 commits into from
Mar 12, 2026
Merged

build: use a shared tsconfig for workspace packages #2532

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d36b40f
build: use minimum support @types/node@18 in development
zimeg Mar 3, 2026
76e02e3
test: use @types/node@18 in development when exporting a range
zimeg Mar 3, 2026
88e3ec7
build: use a shared tsconfig for workspace packages
zimeg Mar 3, 2026
cc3bfc1
chore: centralize shared shx and tsx dependencies
zimeg Mar 3, 2026
4cae3fb
Merge branch 'main' into tsconfig
zimeg Mar 12, 2026
d2412c6
revert: changeset from rebase
zimeg Mar 12, 2026
2ce0633
revert: coauthored by claude
zimeg Mar 12, 2026
dabcefd
Merge branch 'main' into tsconfig
zimeg Mar 12, 2026
2f4dd46
chore(deps): ignore major updates to types/node
zimeg Mar 12, 2026
c78c54d
build: use root types/node@18 for development
zimeg Mar 12, 2026
309a5cf
ci: remove ignore from packages without runtime types/node dependencies
zimeg Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/vast-drinks-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@slack/logger": patch
---

build: remove @types/node from required dependencies
8 changes: 8 additions & 0 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"permissions": {
"allow": [
"Bash(cat:*)",
"Bash(echo:*)",
"Bash(gh issue view:*)",
"Bash(gh label list:*)",
Expand All @@ -10,15 +11,19 @@
"Bash(gh pr status:*)",
"Bash(gh pr update-branch:*)",
"Bash(gh pr view:*)",
"Bash(gh run view:*)",
"Bash(gh search code:*)",
"Bash(git diff:*)",
"Bash(git grep:*)",
"Bash(git log:*)",
"Bash(git ls-tree:*)",
"Bash(git show:*)",
"Bash(git status:*)",
"Bash(grep:*)",
"Bash(head:*)",
"Bash(jq:*)",
"Bash(ls:*)",
"Bash(node --test:*)",
"Bash(node --version:*)",
"Bash(npm --version:*)",
"Bash(npm config:*)",
Expand All @@ -27,7 +32,10 @@
"Bash(npm run build:*)",
"Bash(npm run lint:*)",
"Bash(npm run lint:fix:*)",
"Bash(npm show:*)",
"Bash(npm test:*)",
"Bash(npm version:*)",
"Bash(nvm use:*)",
"Bash(tail:*)",
"Bash(tree:*)",
"WebFetch(domain:docs.slack.dev)",
Expand Down
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
},
"devDependencies": {
"@biomejs/biome": "^2.0.5",
"@changesets/cli": "^2.29.8"
"@changesets/cli": "^2.29.8",
"@types/node": "^18.19.130",
"shx": "^0.4.0",
"tsx": "^4.20.6",
"typescript": "5.9.3"
}
}
23 changes: 4 additions & 19 deletions packages/cli-hooks/jsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,9 @@
{
"$schema": "https://json.schemastore.org/jsconfig",
Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

"extends": "../../tsconfig.base.json",
"compilerOptions": {
"module": "es2022",
"moduleResolution": "node",
"esModuleInterop": true,
"checkJs": true,

"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,

"baseUrl": ".",
"paths": {
"*": ["./types/*"]
}
"checkJs": true
},
"include": ["src/**/*"],
"jsdoc": {
"out": "support/jsdoc",
"access": "public"
}
"include": ["src/**/*"]
}
5 changes: 1 addition & 4 deletions packages/cli-hooks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,8 @@
},
"devDependencies": {
"@types/minimist": "^1.2.5",
"@types/node": "^25.0.3",
"@types/semver": "^7.5.6",
"@types/sinon": "^21.0.0",
"shx": "^0.4.0",
"sinon": "^21.0.0",
"typescript": "5.9.3"
"sinon": "^21.0.0"
}
}
7 changes: 1 addition & 6 deletions packages/cli-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,10 @@
"winston": "^3.8.2"
},
"devDependencies": {
"@tsconfig/recommended": "^1.0.6",
"@types/node": "^25.0.3",
"@types/sinon": "^21.0.0",
"cross-env": "^10.0.0",
"shx": "^0.4.0",
"sinon": "^21.0.0",
"tsx": "^4.20.6",
"typedoc": "^0.28.7",
"typedoc-plugin-markdown": "^4.7.1",
"typescript": "5.9.3"
"typedoc-plugin-markdown": "^4.7.1"
}
}
18 changes: 1 addition & 17 deletions packages/cli-test/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,6 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"declaration": true,
"declarationMap": true,
"esModuleInterop": true,
"noFallthroughCasesInSwitch": true,
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"outDir": "dist",
"skipLibCheck": true,
"sourceMap": true
},
"extends": "@tsconfig/recommended/tsconfig.json",
"extends": "../../tsconfig.base.json",
"include": ["src/**/*"],
"jsdoc": {
"out": "support/jsdoc",
"access": "public"
},
"exclude": ["src/**/*.test.*"]
}
8 changes: 1 addition & 7 deletions packages/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,8 @@
"test:node18": "npm run build && node --test --test-reporter=spec --import tsx --test src/index.test.ts",
"test:unit": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/index.test.ts"
},
"dependencies": {
"@types/node": ">=18.0.0"
},
"devDependencies": {
"shx": "^0.4.0",
"tsx": "^4.20.6",
"typedoc": "^0.28.7",
"typedoc-plugin-markdown": "^4.7.1",
"typescript": "^5.9.3"
"typedoc-plugin-markdown": "^4.7.1"
}
}
31 changes: 2 additions & 29 deletions packages/logger/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,6 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"target": "es2017",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"outDir": "dist",
"skipLibCheck": true,
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"moduleResolution": "node",
"baseUrl": ".",
"paths": {
"*": ["./types/*"]
},
"esModuleInterop": true
// Not using this setting because it's only used to require the package.json file, and that would change the
// structure of the files in the dist directory because package.json is not located inside src. It would be nice
// to use import instead of require(), but it's not worth the tradeoff of restructuring the build (for now).
// "resolveJsonModule": true,
},
"extends": "../../tsconfig.base.json",
"include": ["src/**/*"],
"exclude": ["src/**/*.test.*"],
"jsdoc": {
"out": "support/jsdoc",
"access": "public"
}
"exclude": ["src/**/*.test.*"]
}
5 changes: 1 addition & 4 deletions packages/oauth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,8 @@
"devDependencies": {
"@types/sinon": "^21",
"rewiremock": "^3",
"shx": "^0.4.0",
"sinon": "^21",
"tsx": "^4.20.6",
"typedoc": "^0.28.7",
"typedoc-plugin-markdown": "^4.7.0",
"typescript": "5.9.3"
"typedoc-plugin-markdown": "^4.7.0"
}
}
31 changes: 2 additions & 29 deletions packages/oauth/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,6 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"target": "es5",
Copy link
Copy Markdown
Member Author

@zimeg zimeg Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 note: Since we support a minimum node18 which supports es2022 this changes seems alright to me, but I want to note this will now match the shared es2017 target.

"module": "commonjs",
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"outDir": "dist",
"skipLibCheck": true,
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"moduleResolution": "node",
"baseUrl": ".",
"paths": {
"*": ["./types/*"]
},
"esModuleInterop": true
// Not using this setting because it's only used to require the package.json file, and that would change the
// structure of the files in the dist directory because package.json is not located inside src. It would be nice
// to use import instead of require(), but it's not worth the tradeoff of restructuring the build (for now).
// "resolveJsonModule": true,
},
"extends": "../../tsconfig.base.json",
"include": ["src/**/*"],
"exclude": ["src/**/spec-utils.ts", "src/**/*.test.*"],
"jsdoc": {
"out": "support/jsdoc",
"access": "public"
}
"exclude": ["src/**/spec-utils.ts", "src/**/*.test.*"]
}
5 changes: 1 addition & 4 deletions packages/rtm-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,8 @@
"devDependencies": {
"@types/sinon": "^17",
"@types/ws": "^8",
"shx": "^0.3.2",
"sinon": "^21",
"tsx": "^4.20.6",
"typedoc": "^0.28.7",
"typedoc-plugin-markdown": "^4.7.1",
"typescript": "5.9.3"
"typedoc-plugin-markdown": "^4.7.1"
}
}
31 changes: 2 additions & 29 deletions packages/rtm-api/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,6 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"target": "es2017",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"outDir": "dist",
"skipLibCheck": true,
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"moduleResolution": "node",
"baseUrl": ".",
"paths": {
"*": ["./types/*"]
},
"esModuleInterop": true
// Not using this setting because it's only used to require the package.json file, and that would change the
// structure of the files in the dist directory because package.json is not located inside src. It would be nice
// to use import instead of require(), but it's not worth the tradeoff of restructuring the build (for now).
// "resolveJsonModule": true,
},
"extends": "../../tsconfig.base.json",
"include": ["src/**/*"],
"exclude": ["src/**/*.spec.*"],
"jsdoc": {
"out": "support/jsdoc",
"access": "public"
}
"exclude": ["src/**/*.test.*"]
}
6 changes: 1 addition & 5 deletions packages/socket-mode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,12 @@
"ws": "^8"
},
"devDependencies": {
"@tsconfig/recommended": "^1.0.7",
"@types/proxyquire": "^1.3.31",
"@types/sinon": "^21",
"nodemon": "^3.1.0",
"proxyquire": "^2.1.3",
"shx": "^0.4.0",
"sinon": "^21",
"tsx": "^4.20.6",
"typedoc": "^0.28.7",
"typedoc-plugin-markdown": "^4.7.0",
"typescript": "5.9.3"
"typedoc-plugin-markdown": "^4.7.0"
}
}
19 changes: 3 additions & 16 deletions packages/socket-mode/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,9 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"declaration": true,
"declarationMap": true,
"noFallthroughCasesInSwitch": true,
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"outDir": "dist",
"resolveJsonModule": true,
"skipLibCheck": true,
"sourceMap": true
"resolveJsonModule": true
},
"extends": "@tsconfig/recommended/tsconfig.json",
"include": ["src/**/*"],
"exclude": ["src/**/*.test.*"],
"jsdoc": {
"out": "support/jsdoc",
"access": "public"
}
"exclude": ["src/**/*.test.*"]
}
4 changes: 1 addition & 3 deletions packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,9 @@
"test:types": "tsd"
},
"devDependencies": {
"shx": "^0.4.0",
"tsd": "^0.33.0",
"typedoc": "^0.28.7",
"typedoc-plugin-markdown": "^4.7.1",
"typescript": "^5.9.3"
"typedoc-plugin-markdown": "^4.7.1"
},
"tsd": {
"directory": "test"
Expand Down
31 changes: 2 additions & 29 deletions packages/types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,6 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"target": "es2017",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"outDir": "dist",
"skipLibCheck": true,
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"moduleResolution": "node",
"baseUrl": ".",
"paths": {
"*": ["./types/*"]
},
"esModuleInterop": true
// Not using this setting because it's only used to require the package.json file, and that would change the
// structure of the files in the dist directory because package.json is not located inside src. It would be nice
// to use import instead of require(), but it's not worth the tradeoff of restructuring the build (for now).
// "resolveJsonModule": true,
},
"extends": "../../tsconfig.base.json",
"include": ["src/**/*"],
"exclude": ["src/**/*.spec.*"],
"jsdoc": {
"out": "support/jsdoc",
"access": "public"
}
"exclude": ["src/**/*.test.*"]
}
Loading