refactor(cli-test)!: rename env add/remove to env set/unset#2545
Draft
refactor(cli-test)!: rename env add/remove to env set/unset#2545
Conversation
Aligns with Slack CLI rename of `env add` → `env set` and `env remove` → `env unset` from slackapi/slack-cli#460. - Rename `SLACK_TRACE_ENV_ADD_SUCCESS` → `SLACK_TRACE_ENV_SET_SUCCESS` - Rename `SLACK_TRACE_ENV_REMOVE_SUCCESS` → `SLACK_TRACE_ENV_UNSET_SUCCESS` - Rename exported `add`/`remove` functions to `set`/`unset` - Update tests and regenerate docs Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 2ffa200 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
==========================================
- Coverage 87.40% 87.39% -0.01%
==========================================
Files 62 62
Lines 10235 10235
Branches 409 409
==========================================
- Hits 8946 8945 -1
- Misses 1267 1268 +1
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env add→env setandenv remove→env unsetcommands in@slack/cli-testSLACK_TRACE_ENV_ADD_SUCCESS→SLACK_TRACE_ENV_SET_SUCCESSandSLACK_TRACE_ENV_REMOVE_SUCCESS→SLACK_TRACE_ENV_UNSET_SUCCESStrace constantsenv setandenv unsetas primary commands slack-cli#460Changes
packages/cli-test/src/utils/constants.ts— updated trace ID constantspackages/cli-test/src/cli/commands/env.ts— renamedadd→set,remove→unsetfunctions and CLI subcommandspackages/cli-test/src/cli/commands/env.test.ts— updated testsTest plan
npm test --workspace=packages/cli-test— all 28 tests passnpx biome check— no lint issues🤖 Generated with Claude Code
Co-Authored-By: Claude svc-devxp-claude@slack-corp.com