chore: drop Node.js 18 support for relevant packages#2572
chore: drop Node.js 18 support for relevant packages#2572WilliamBergamin merged 7 commits intov8{webook,web-api}from
Conversation
🦋 Changeset detectedLatest commit: a4dbb88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v8{webook,web-api} #2572 +/- ##
===================================================
Coverage 87.38% 87.38%
===================================================
Files 62 62
Lines 10256 10256
Branches 415 415
===================================================
Hits 8962 8962
Misses 1273 1273
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin Huge thanks for getting this started! Let's note this toward #2359 🐙
I'm approving now but left a few thoughts and comments. Before merging I'm most curious about:
- Freezing the
@slack/rtm-apipackage - Increasing the minimum
npmversion
The standard packages of these later versions are so exciting to unlock 🔏 🦕
| ], | ||
| "engines": { | ||
| "node": ">= 18", | ||
| "node": ">= 20", |
There was a problem hiding this comment.
🔭 note(non-blocking): We might want to find the LTS version of this minimum? Perhaps not for 20 but in future updates this might guarantee more stable app code:
This release marks the transition of Node.js 24.x into Long Term Support (LTS).
There was a problem hiding this comment.
🧊 suggestion: We might want to keep this package frozen?
Beginning March 31, 2025, we will discontinue support for legacy custom bots.
🔗 https://docs.slack.dev/changelog/2024-09-legacy-custom-bots-classic-apps-deprecation/
There was a problem hiding this comment.
Good point 💯
| "engines": { | ||
| "node": ">= 12.13.0", | ||
| "npm": ">= 6.12.0" | ||
| "node": ">= 20", |
There was a problem hiding this comment.
⭐ praise: I understand this is a significant change but should make maintenance much better ongoing!
🪬 thought: We might be confident that developers update to the latest package versions and using the latest Slack features are using more recent versions of node too?
There was a problem hiding this comment.
I'm not sure of the use case where this package is used standalone, from what I understand it should be used in combination with another one of our packages that now require node 20 🤔
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Summary
Node.js 18 reached end-of-life on April 30, 2025. This raises the minimum supported Node.js version to 20 for
@slack/cli-hooks,@slack/cli-test,@slack/logger,@slack/oauth,@slack/socket-mode,@slack/types,@slack/web-apiand@slack/webhook, ahead of the upcoming axios-to-fetch migration.Requirements