Skip to content

Commit 16741f8

Browse files
authored
fix(web-api): use json content type for chat stream methods (#1749)
1 parent 8519684 commit 16741f8

File tree

4 files changed

+22
-11
lines changed

4 files changed

+22
-11
lines changed

slack_sdk/web/async_client.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2641,7 +2641,8 @@ async def chat_appendStream(
26412641
"markdown_text": markdown_text,
26422642
}
26432643
)
2644-
return await self.api_call("chat.appendStream", params=kwargs)
2644+
kwargs = _remove_none_values(kwargs)
2645+
return await self.api_call("chat.appendStream", json=kwargs)
26452646

26462647
async def chat_delete(
26472648
self,
@@ -2895,7 +2896,8 @@ async def chat_startStream(
28952896
"unfurl_media": unfurl_media,
28962897
}
28972898
)
2898-
return await self.api_call("chat.startStream", params=kwargs)
2899+
kwargs = _remove_none_values(kwargs)
2900+
return await self.api_call("chat.startStream", json=kwargs)
28992901

29002902
async def chat_stopStream(
29012903
self,
@@ -2920,7 +2922,8 @@ async def chat_stopStream(
29202922
}
29212923
)
29222924
_parse_web_class_objects(kwargs)
2923-
return await self.api_call("chat.stopStream", params=kwargs)
2925+
kwargs = _remove_none_values(kwargs)
2926+
return await self.api_call("chat.stopStream", json=kwargs)
29242927

29252928
async def chat_unfurl(
29262929
self,

slack_sdk/web/client.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2631,7 +2631,8 @@ def chat_appendStream(
26312631
"markdown_text": markdown_text,
26322632
}
26332633
)
2634-
return self.api_call("chat.appendStream", params=kwargs)
2634+
kwargs = _remove_none_values(kwargs)
2635+
return self.api_call("chat.appendStream", json=kwargs)
26352636

26362637
def chat_delete(
26372638
self,
@@ -2885,7 +2886,8 @@ def chat_startStream(
28852886
"unfurl_media": unfurl_media,
28862887
}
28872888
)
2888-
return self.api_call("chat.startStream", params=kwargs)
2889+
kwargs = _remove_none_values(kwargs)
2890+
return self.api_call("chat.startStream", json=kwargs)
28892891

28902892
def chat_stopStream(
28912893
self,
@@ -2910,7 +2912,8 @@ def chat_stopStream(
29102912
}
29112913
)
29122914
_parse_web_class_objects(kwargs)
2913-
return self.api_call("chat.stopStream", params=kwargs)
2915+
kwargs = _remove_none_values(kwargs)
2916+
return self.api_call("chat.stopStream", json=kwargs)
29142917

29152918
def chat_unfurl(
29162919
self,

slack_sdk/web/legacy_client.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2643,7 +2643,8 @@ def chat_appendStream(
26432643
"markdown_text": markdown_text,
26442644
}
26452645
)
2646-
return self.api_call("chat.appendStream", params=kwargs)
2646+
kwargs = _remove_none_values(kwargs)
2647+
return self.api_call("chat.appendStream", json=kwargs)
26472648

26482649
def chat_delete(
26492650
self,
@@ -2897,7 +2898,8 @@ def chat_startStream(
28972898
"unfurl_media": unfurl_media,
28982899
}
28992900
)
2900-
return self.api_call("chat.startStream", params=kwargs)
2901+
kwargs = _remove_none_values(kwargs)
2902+
return self.api_call("chat.startStream", json=kwargs)
29012903

29022904
def chat_stopStream(
29032905
self,
@@ -2922,7 +2924,8 @@ def chat_stopStream(
29222924
}
29232925
)
29242926
_parse_web_class_objects(kwargs)
2925-
return self.api_call("chat.stopStream", params=kwargs)
2927+
kwargs = _remove_none_values(kwargs)
2928+
return self.api_call("chat.stopStream", json=kwargs)
29262929

29272930
def chat_unfurl(
29282931
self,

tests/slack_sdk_async/web/test_web_client_coverage.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -571,8 +571,10 @@ async def run_method(self, method_name, method, async_method):
571571
self.api_methods_to_call.remove(method(channel="C123")["method"])
572572
await async_method(channel="C123")
573573
elif method_name == "chat_stopStream":
574-
self.api_methods_to_call.remove(method(channel="C123", ts="123.123")["method"])
575-
await async_method(channel="C123", ts="123.123")
574+
self.api_methods_to_call.remove(
575+
method(channel="C123", ts="123.123", blocks=[{"type": "markdown", "text": "**twelve**"}])["method"]
576+
)
577+
await async_method(channel="C123", ts="123.123", blocks=[{"type": "markdown", "text": "**twelve**"}])
576578
elif method_name == "chat_unfurl":
577579
self.api_methods_to_call.remove(
578580
method(

0 commit comments

Comments
 (0)