Skip to content

Commit 17b6abd

Browse files
pedromcaraujoRodneyU215
authored andcommitted
Remove value from LinkButtonElement, fix test (#563)
1 parent 3323408 commit 17b6abd

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

slack/web/classes/elements.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,13 @@ def __init__(self, *, text: str, url: str, style: Optional[str] = None):
159159
def url_length(self):
160160
return len(self.url) <= self.url_max_length
161161

162+
def to_dict(self) -> dict:
163+
json = super().to_dict()
164+
# LinkButtonElements don't use the value property so we can just remove it
165+
if "value" in json:
166+
del json["value"]
167+
return json
168+
162169

163170
class AbstractSelector(InteractiveElement, metaclass=ABCMeta):
164171
placeholder_max_length = 150

tests/web/classes/test_elements.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ def test_json(self):
8484
"text": {"emoji": True, "text": "button text", "type": "plain_text"},
8585
"url": "http://google.com",
8686
"type": "button",
87-
"value": "",
8887
"action_id": button.action_id,
8988
},
9089
)

0 commit comments

Comments
 (0)