Skip to content

Commit 2390de8

Browse files
committed
fix: send structured values using json content type
1 parent 262a7b9 commit 2390de8

File tree

4 files changed

+18
-3
lines changed

4 files changed

+18
-3
lines changed

slack_sdk/web/async_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2084,7 +2084,8 @@ async def assistant_threads_setStatus(
20842084
kwargs.update(
20852085
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
20862086
)
2087-
return await self.api_call("assistant.threads.setStatus", params=kwargs)
2087+
kwargs = _remove_none_values(kwargs)
2088+
return await self.api_call("assistant.threads.setStatus", json=kwargs)
20882089

20892090
async def assistant_threads_setTitle(
20902091
self,

slack_sdk/web/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2074,7 +2074,8 @@ def assistant_threads_setStatus(
20742074
kwargs.update(
20752075
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
20762076
)
2077-
return self.api_call("assistant.threads.setStatus", params=kwargs)
2077+
kwargs = _remove_none_values(kwargs)
2078+
return self.api_call("assistant.threads.setStatus", json=kwargs)
20782079

20792080
def assistant_threads_setTitle(
20802081
self,

slack_sdk/web/legacy_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2086,7 +2086,8 @@ def assistant_threads_setStatus(
20862086
kwargs.update(
20872087
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
20882088
)
2089-
return self.api_call("assistant.threads.setStatus", params=kwargs)
2089+
kwargs = _remove_none_values(kwargs)
2090+
return self.api_call("assistant.threads.setStatus", json=kwargs)
20902091

20912092
def assistant_threads_setTitle(
20922093
self,

tests/slack_sdk_async/web/test_web_client_coverage.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,19 @@ async def run_method(self, method_name, method, async_method):
425425
self.api_methods_to_call.remove(
426426
method(channel_id="D111", thread_ts="111.222", status="is typing...")["method"]
427427
)
428+
method(
429+
channel_id="D111",
430+
thread_ts="111.222",
431+
status="is typing...",
432+
loading_states=["Thinking...", "Writing..."],
433+
)
428434
await async_method(channel_id="D111", thread_ts="111.222", status="is typing...")
435+
await async_method(
436+
channel_id="D111",
437+
thread_ts="111.222",
438+
status="is typing...",
439+
loading_states=["Thinking...", "Writing..."],
440+
)
429441
elif method_name == "assistant_threads_setTitle":
430442
self.api_methods_to_call.remove(method(channel_id="D111", thread_ts="111.222", title="New chat")["method"])
431443
await async_method(channel_id="D111", thread_ts="111.222", title="New chat")

0 commit comments

Comments
 (0)