Skip to content

Commit 26ba131

Browse files
committed
Address comments and simplify black versioning.
1 parent 91fa478 commit 26ba131

File tree

8 files changed

+9
-10
lines changed

8 files changed

+9
-10
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ Are you looking for [slackclient](https://pypi.org/project/slackclient/)? The sl
6666

6767
---
6868

69-
This library requires Python 3.7 and above. If you require Python 2, please use our [SlackClient - v1.x][slackclientv1]. If you're unsure how to check what version of Python you're on, you can check it using the following:
69+
This library requires Python 3.7 and above. If you're unsure how to check what version of Python you're on, you can check it using the following:
7070

7171
> **Note:** You may need to use `python3` before your commands to ensure you use the correct Python path. e.g. `python3 --version`
7272

docs/english/legacy/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Refer to the [migration guide](/tools/python-slack-sdk/v3-migration) to learn ho
1010

1111
Slack APIs allow anyone to build full featured integrations that extend and expand the capabilities of your Slack workspace. These APIs allow you to build applications that interact with Slack just like the people on your team. They can post messages, respond to events that happen, and build complex UIs for getting work done.
1212

13-
To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK.
13+
To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher.
1414

1515
## Slack platform basics {#platform-basics}
1616

docs/english/v3-migration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ If you don't wish to upgrade yet, be sure to pin your module for the Python `sla
6969

7070
### Minimum Python versions {#minimum-versions}
7171

72-
`slackclient` v2.x requires Python 3.7 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x.
72+
`slackclient` v2.x requires Python 3.7 (or higher).
7373

7474
Client v1 support:
7575
- Python 2: Python 2.7 was supported in the 1.x version of the client up until Dec 31st, 2019.

integration_tests/web/test_issue_480.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ async def test_issue_480_processes_async(self):
4343
after = len(multiprocessing.active_children())
4444
self.assertEqual(0, after - before)
4545

46-
# fails with Python 3.6 (no longer supported)
46+
# fails with Python 3.6
4747
def test_issue_480_threads(self):
4848
client = self.sync_client
4949
before = threading.active_count()
@@ -53,7 +53,7 @@ def test_issue_480_threads(self):
5353
after = threading.active_count()
5454
self.assertEqual(0, after - before)
5555

56-
# fails with Python 3.6 (no longer supported)
56+
# fails with Python 3.6
5757
@async_test
5858
async def test_issue_480_threads_async(self):
5959
client = self.async_client

requirements/testing.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ pytest-cov>=2,<7
88
flake8>=5.0.4,<8
99
# Don't change this version without running CI builds;
1010
# The latest version may not be available for older Python runtime
11-
black>=22.8.0; python_version=="3.7"
12-
black==22.10.0; python_version>="3.8"
11+
black==22.10.0;
1312
click==8.0.4 # black is affected by https://github.com/pallets/click/issues/2225
1413
psutil>=6.0.0,<8
1514
# used only under slack_sdk/*_store

slack_sdk/web/internal_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def get_user_agent(prefix: Optional[str] = None, suffix: Optional[str] = None):
4444
4545
Returns:
4646
The user agent string.
47-
e.g. 'Python/3.7.0 slackclient/2.0.0 Darwin/17.7.0'
47+
e.g. 'Python/3.7.17 slackclient/2.0.0 Darwin/17.7.0'
4848
"""
4949
# __name__ returns all classes, we only want the client
5050
client = "{0}/{1}".format("slackclient", version.__version__)

tests/test_aiohttp_version_checker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def print(message: str):
1919

2020
validate_aiohttp_version("2.1.3", print)
2121
self.assertEqual(state["counter"], 1)
22-
validate_aiohttp_version("3.7.0", print)
22+
validate_aiohttp_version("3.6.3", print)
2323
self.assertEqual(state["counter"], 2)
2424
validate_aiohttp_version("3.7.0", print)
2525
self.assertEqual(state["counter"], 3)

tutorial/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Before anything else you'll need a Slack team. You can [Sign into an existing Sl
2525
Check your installation by running the following command in your terminal:
2626
```
2727
$ python3 --version
28-
-> Python 3.7.0
28+
-> Python 3.7.17
2929
```
3030

3131
You'll need to install Python 3.7 if you receive the following error:

0 commit comments

Comments
 (0)