test: fix typechecks and unit tests

Author: zimeg

slack_sdk/models/blocks/basic_components.py

@@ -573,7 +573,7 @@ def value_length(self) -> bool:
 
     def to_dict(self) -> Dict[str, Any]:
         self.validate_json()
-        json = {}
+        json: Dict[str, Union[str, dict]] = {}
         if self._text:
             json["text"] = self._text.to_dict()
         if self._accessibility_label:

tests/slack_sdk/models/test_objects.py

@@ -365,13 +365,13 @@ def test_deny_length(self):
 class FeedbackButtonObjectTests(unittest.TestCase):
     def test_basic_json(self):
         feedback_button = FeedbackButtonObject(text="+1", value="positive")
-        expected = {"text": PlainTextObject(text="+1"), "value": "positive"}
+        expected = {"text": {"emoji": True, "text": "+1", "type": "plain_text"}, "value": "positive"}
         self.assertDictEqual(expected, feedback_button.to_dict())
 
     def test_with_accessibility_label(self):
         feedback_button = FeedbackButtonObject(text="+1", value="positive", accessibility_label="Positive feedback button")
         expected = {
-            "text": PlainTextObject(text="+1"),
+            "text": {"emoji": True, "text": "+1", "type": "plain_text"},
             "value": "positive",
             "accessibility_label": "Positive feedback button",
         }
@@ -381,7 +381,7 @@ def test_with_plain_text_object(self):
         text_obj = PlainTextObject(text="-1", emoji=False)
         feedback_button = FeedbackButtonObject(text=text_obj, value="negative")
         expected = {
-            "text": PlainTextObject(text="-1"),
+            "text": {"emoji": False, "text": "-1", "type": "plain_text"},
             "value": "negative",
         }
         self.assertDictEqual(expected, feedback_button.to_dict())
@@ -399,7 +399,7 @@ def test_parse_from_dict(self):
         parsed = FeedbackButtonObject.parse(data)
         self.assertIsInstance(parsed, FeedbackButtonObject)
         expected = {
-            "text": PlainTextObject(text="+1"),
+            "text": {"emoji": True, "text": "+1", "type": "plain_text"},
             "value": "positive",
             "accessibility_label": "Positive feedback",
         }