Skip to content

Commit 49229e1

Browse files
committed
test: fix expected types
1 parent e9a97f1 commit 49229e1

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

tests/slack_sdk/models/test_blocks.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
StaticSelectElement,
3232
VideoBlock,
3333
)
34-
from slack_sdk.models.blocks.basic_components import SlackFile
34+
from slack_sdk.models.blocks.basic_components import FeedbackButtonObject, SlackFile
35+
from slack_sdk.models.blocks.block_elements import FeedbackButtonsElement, IconButtonElement
3536

3637
from . import STRING_3001_CHARS
3738

@@ -557,17 +558,17 @@ def test_document(self):
557558
self.assertDictEqual(input, Block.parse(input).to_dict())
558559

559560
def test_with_feedback_buttons(self):
560-
feedback_buttons = FeedbackButtons(
561+
feedback_buttons = FeedbackButtonsElement(
561562
action_id="feedback-action",
562-
positive_button={"text": {"type": "plain_text", "text": "Good"}, "value": "positive"},
563-
negative_button={"text": {"type": "plain_text", "text": "Bad"}, "value": "negative"},
563+
positive_button=FeedbackButtonObject(text="Good", value="positive"),
564+
negative_button=FeedbackButtonObject(text="Bad", value="negative"),
564565
)
565566
block = ContextActionsBlock(elements=[feedback_buttons])
566567
self.assertEqual(len(block.elements), 1)
567568
self.assertEqual(block.elements[0].type, "feedback_buttons")
568569

569570
def test_with_icon_button(self):
570-
icon_button = IconButton(
571+
icon_button = IconButtonElement(
571572
action_id="icon-action", icon="star", text=PlainTextObject(text="Favorite"), value="favorite"
572573
)
573574
block = ContextActionsBlock(elements=[icon_button])

tests/slack_sdk/models/test_objects.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,13 +365,13 @@ def test_deny_length(self):
365365
class FeedbackButtonObjectTests(unittest.TestCase):
366366
def test_basic_json(self):
367367
feedback_button = FeedbackButtonObject(text="+1", value="positive")
368-
expected = {"text": {"type": "plain_text", "text": "+1", "emoji": True}, "value": "positive"}
368+
expected = {"text": PlainTextObject(text="+1"), "value": "positive"}
369369
self.assertDictEqual(expected, feedback_button.to_dict())
370370

371371
def test_with_accessibility_label(self):
372372
feedback_button = FeedbackButtonObject(text="+1", value="positive", accessibility_label="Positive feedback button")
373373
expected = {
374-
"text": {"type": "plain_text", "text": "+1", "emoji": True},
374+
"text": PlainTextObject(text="+1"),
375375
"value": "positive",
376376
"accessibility_label": "Positive feedback button",
377377
}
@@ -380,7 +380,10 @@ def test_with_accessibility_label(self):
380380
def test_with_plain_text_object(self):
381381
text_obj = PlainTextObject(text="-1", emoji=False)
382382
feedback_button = FeedbackButtonObject(text=text_obj, value="negative")
383-
expected = {"text": {"type": "plain_text", "text": "-1", "emoji": False}, "value": "negative"}
383+
expected = {
384+
"text": PlainTextObject(text="-1"),
385+
"value": "negative",
386+
}
384387
self.assertDictEqual(expected, feedback_button.to_dict())
385388

386389
def test_text_length_validation(self):
@@ -396,7 +399,7 @@ def test_parse_from_dict(self):
396399
parsed = FeedbackButtonObject.parse(data)
397400
self.assertIsInstance(parsed, FeedbackButtonObject)
398401
expected = {
399-
"text": {"type": "plain_text", "text": "+1", "emoji": True},
402+
"text": PlainTextObject(text="+1"),
400403
"value": "positive",
401404
"accessibility_label": "Positive feedback",
402405
}

0 commit comments

Comments
 (0)