Skip to content

Commit 6443d1b

Browse files
committed
Update the pull request template
1 parent 32d8ae9 commit 6443d1b

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

.github/pull_request_template.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66

77
- [ ] **slack_sdk.web.WebClient (sync/async)** (Web API client)
88
- [ ] **slack_sdk.webhook.WebhookClient (sync/async)** (Incoming Webhook, response_url sender)
9-
- [ ] **slack_sdk.models** (UI component builders)
10-
- [ ] **slack_sdk.oauth** (OAuth Flow Utilities)
119
- [ ] **slack_sdk.socket_mode** (Socket Mode client)
12-
- [ ] **slack_sdk.audit_logs** (Audit Logs API client)
13-
- [ ] **slack_sdk.scim** (SCIM API client)
14-
- [ ] **slack_sdk.rtm** (RTM client)
1510
- [ ] **slack_sdk.signature** (Request Signature Verifier)
11+
- [ ] **slack_sdk.oauth** (OAuth Flow Utilities)
12+
- [ ] **slack_sdk.models** (UI component builders)
13+
- [ ] **slack_sdk.scim** (SCIM API client)
14+
- [ ] **slack_sdk.audit_logs** (Audit Logs API client)
15+
- [ ] **slack_sdk.rtm_v2** (RTM client)
1616
- [ ] `/docs-src` (Documents, have you run `./docs.sh`?)
1717
- [ ] `/docs-src-v2` (Documents, have you run `./docs-v2.sh`?)
1818
- [ ] `/tutorial` (PythOnBoardingBot tutorial)
@@ -22,4 +22,4 @@
2222

2323
- [ ] I've read and understood the [Contributing Guidelines](https://github.com/slackapi/python-slack-sdk/blob/main/.github/contributing.md) and have done my best effort to follow them.
2424
- [ ] I've read and agree to the [Code of Conduct](https://slackhq.github.io/code-of-conduct).
25-
- [ ] I've run `python setup.py validate` after making the changes.
25+
- [ ] I've run `python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh` after making the changes.

scripts/run_validation.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
script_dir=`dirname $0`
55
cd ${script_dir}/..
6-
pip install "black==21.5b1"
7-
black slack_sdk/ slack/ tests/ && \
6+
pip install -U pip && \
7+
pip install -e ".[testing]" && \
8+
pip install -e ".[optional]" && \
9+
black slack_sdk/ slack/ tests/ && \
810
python setup.py codegen && \
911
python setup.py validate

0 commit comments

Comments
 (0)