Skip to content

Commit 829d409

Browse files
zimegmwbrooks
zimeg
and
mwbrooks
authored
fix(web): send structured values to "assistant.threads.setStatus" method using json content type (#1754)
Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>
1 parent f901e25 commit 829d409

File tree

9 files changed

+38
-13
lines changed

9 files changed

+38
-13
lines changed

‎docs/reference/index.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2210,7 +2210,8 @@ <h2 class="section-title" id="header-classes">Classes</h2>
22102210
kwargs.update(
22112211
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
22122212
)
2213-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)
2213+
kwargs = _remove_none_values(kwargs)
2214+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)
22142215

22152216
def assistant_threads_setTitle(
22162217
self,
@@ -8991,7 +8992,8 @@ <h3>Methods</h3>
89918992
kwargs.update(
89928993
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
89938994
)
8994-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)</code></pre>
8995+
kwargs = _remove_none_values(kwargs)
8996+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)</code></pre>
89958997
</details>
89968998
<div class="desc"><p>Set the status for an AI assistant thread.
89978999
<a href="https://api.slack.com/methods/assistant.threads.setStatus">https://api.slack.com/methods/assistant.threads.setStatus</a></p></div>

‎docs/reference/web/async_client.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2106,7 +2106,8 @@ <h2 class="section-title" id="header-classes">Classes</h2>
21062106
kwargs.update(
21072107
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
21082108
)
2109-
return await self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)
2109+
kwargs = _remove_none_values(kwargs)
2110+
return await self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)
21102111

21112112
async def assistant_threads_setTitle(
21122113
self,
@@ -8887,7 +8888,8 @@ <h3>Methods</h3>
88878888
kwargs.update(
88888889
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
88898890
)
8890-
return await self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)</code></pre>
8891+
kwargs = _remove_none_values(kwargs)
8892+
return await self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)</code></pre>
88918893
</details>
88928894
<div class="desc"><p>Set the status for an AI assistant thread.
88938895
<a href="https://api.slack.com/methods/assistant.threads.setStatus">https://api.slack.com/methods/assistant.threads.setStatus</a></p></div>

‎docs/reference/web/client.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2106,7 +2106,8 @@ <h2 class="section-title" id="header-classes">Classes</h2>
21062106
kwargs.update(
21072107
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
21082108
)
2109-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)
2109+
kwargs = _remove_none_values(kwargs)
2110+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)
21102111

21112112
def assistant_threads_setTitle(
21122113
self,
@@ -8887,7 +8888,8 @@ <h3>Methods</h3>
88878888
kwargs.update(
88888889
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
88898890
)
8890-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)</code></pre>
8891+
kwargs = _remove_none_values(kwargs)
8892+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)</code></pre>
88918893
</details>
88928894
<div class="desc"><p>Set the status for an AI assistant thread.
88938895
<a href="https://api.slack.com/methods/assistant.threads.setStatus">https://api.slack.com/methods/assistant.threads.setStatus</a></p></div>

‎docs/reference/web/index.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2467,7 +2467,8 @@ <h2 id="raises">Raises</h2>
24672467
kwargs.update(
24682468
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
24692469
)
2470-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)
2470+
kwargs = _remove_none_values(kwargs)
2471+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)
24712472

24722473
def assistant_threads_setTitle(
24732474
self,
@@ -9248,7 +9249,8 @@ <h3>Methods</h3>
92489249
kwargs.update(
92499250
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
92509251
)
9251-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)</code></pre>
9252+
kwargs = _remove_none_values(kwargs)
9253+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)</code></pre>
92529254
</details>
92539255
<div class="desc"><p>Set the status for an AI assistant thread.
92549256
<a href="https://api.slack.com/methods/assistant.threads.setStatus">https://api.slack.com/methods/assistant.threads.setStatus</a></p></div>

‎docs/reference/web/legacy_client.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2105,7 +2105,8 @@ <h2 class="section-title" id="header-classes">Classes</h2>
21052105
kwargs.update(
21062106
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
21072107
)
2108-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)
2108+
kwargs = _remove_none_values(kwargs)
2109+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)
21092110

21102111
def assistant_threads_setTitle(
21112112
self,
@@ -8886,7 +8887,8 @@ <h3>Methods</h3>
88868887
kwargs.update(
88878888
{&#34;channel_id&#34;: channel_id, &#34;thread_ts&#34;: thread_ts, &#34;status&#34;: status, &#34;loading_messages&#34;: loading_messages}
88888889
)
8889-
return self.api_call(&#34;assistant.threads.setStatus&#34;, params=kwargs)</code></pre>
8890+
kwargs = _remove_none_values(kwargs)
8891+
return self.api_call(&#34;assistant.threads.setStatus&#34;, json=kwargs)</code></pre>
88908892
</details>
88918893
<div class="desc"><p>Set the status for an AI assistant thread.
88928894
<a href="https://api.slack.com/methods/assistant.threads.setStatus">https://api.slack.com/methods/assistant.threads.setStatus</a></p></div>

‎slack_sdk/web/async_client.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2084,7 +2084,8 @@ async def assistant_threads_setStatus(
20842084
kwargs.update(
20852085
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
20862086
)
2087-
return await self.api_call("assistant.threads.setStatus", params=kwargs)
2087+
kwargs = _remove_none_values(kwargs)
2088+
return await self.api_call("assistant.threads.setStatus", json=kwargs)
20882089

20892090
async def assistant_threads_setTitle(
20902091
self,

‎slack_sdk/web/client.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2074,7 +2074,8 @@ def assistant_threads_setStatus(
20742074
kwargs.update(
20752075
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
20762076
)
2077-
return self.api_call("assistant.threads.setStatus", params=kwargs)
2077+
kwargs = _remove_none_values(kwargs)
2078+
return self.api_call("assistant.threads.setStatus", json=kwargs)
20782079

20792080
def assistant_threads_setTitle(
20802081
self,

‎slack_sdk/web/legacy_client.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2086,7 +2086,8 @@ def assistant_threads_setStatus(
20862086
kwargs.update(
20872087
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
20882088
)
2089-
return self.api_call("assistant.threads.setStatus", params=kwargs)
2089+
kwargs = _remove_none_values(kwargs)
2090+
return self.api_call("assistant.threads.setStatus", json=kwargs)
20902091

20912092
def assistant_threads_setTitle(
20922093
self,

‎tests/slack_sdk_async/web/test_web_client_coverage.py‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,19 @@ async def run_method(self, method_name, method, async_method):
425425
self.api_methods_to_call.remove(
426426
method(channel_id="D111", thread_ts="111.222", status="is typing...")["method"]
427427
)
428+
method(
429+
channel_id="D111",
430+
thread_ts="111.222",
431+
status="is typing...",
432+
loading_states=["Thinking...", "Writing..."],
433+
)
428434
await async_method(channel_id="D111", thread_ts="111.222", status="is typing...")
435+
await async_method(
436+
channel_id="D111",
437+
thread_ts="111.222",
438+
status="is typing...",
439+
loading_states=["Thinking...", "Writing..."],
440+
)
429441
elif method_name == "assistant_threads_setTitle":
430442
self.api_methods_to_call.remove(method(channel_id="D111", thread_ts="111.222", title="New chat")["method"])
431443
await async_method(channel_id="D111", thread_ts="111.222", title="New chat")

0 commit comments

Comments
 (0)