refactor: simplify highlight_type passthrough by widening type annotation

Rely on the existing None-stripping logic in files_completeUploadExternal
instead of conditionally building the dict.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Author: zimeg

slack_sdk/web/async_client.py

@@ -4119,14 +4119,8 @@ async def files_upload_v2(
                 raise e.SlackRequestError(message)
 
         # step3: files.completeUploadExternal with all the sets of (file_id + title)
-        complete_files = []
-        for f in files:
-            file_entry: Dict[str, str] = {"id": f["file_id"], "title": f["title"]}
-            if f.get("highlight_type") is not None:
-                file_entry["highlight_type"] = f["highlight_type"]
-            complete_files.append(file_entry)
         completion = await self.files_completeUploadExternal(
-            files=complete_files,
+            files=[{"id": f["file_id"], "title": f["title"], "highlight_type": f.get("highlight_type")} for f in files],
             channel_id=channel,
             channels=channels,
             initial_comment=initial_comment,
@@ -4162,7 +4156,7 @@ async def files_getUploadURLExternal(
     async def files_completeUploadExternal(
         self,
         *,
-        files: List[Dict[str, str]],
+        files: List[Dict[str, Optional[str]]],
         channel_id: Optional[str] = None,
         channels: Optional[List[str]] = None,
         initial_comment: Optional[str] = None,

slack_sdk/web/client.py

@@ -4109,14 +4109,8 @@ def files_upload_v2(
                 raise e.SlackRequestError(message)
 
         # step3: files.completeUploadExternal with all the sets of (file_id + title)
-        complete_files = []
-        for f in files:
-            file_entry: Dict[str, str] = {"id": f["file_id"], "title": f["title"]}
-            if f.get("highlight_type") is not None:
-                file_entry["highlight_type"] = f["highlight_type"]
-            complete_files.append(file_entry)
         completion = self.files_completeUploadExternal(
-            files=complete_files,
+            files=[{"id": f["file_id"], "title": f["title"], "highlight_type": f.get("highlight_type")} for f in files],
             channel_id=channel,
             channels=channels,
             initial_comment=initial_comment,
@@ -4152,7 +4146,7 @@ def files_getUploadURLExternal(
     def files_completeUploadExternal(
         self,
         *,
-        files: List[Dict[str, str]],
+        files: List[Dict[str, Optional[str]]],
         channel_id: Optional[str] = None,
         channels: Optional[List[str]] = None,
         initial_comment: Optional[str] = None,

slack_sdk/web/legacy_client.py

@@ -4044,14 +4044,8 @@ def files_upload_v2(
                 raise e.SlackRequestError(message)
 
         # step3: files.completeUploadExternal with all the sets of (file_id + title)
-        complete_files = []
-        for f in files:
-            file_entry: Dict[str, str] = {"id": f["file_id"], "title": f["title"]}
-            if f.get("highlight_type") is not None:
-                file_entry["highlight_type"] = f["highlight_type"]
-            complete_files.append(file_entry)
         completion = self.files_completeUploadExternal(
-            files=complete_files,
+            files=[{"id": f["file_id"], "title": f["title"], "highlight_type": f.get("highlight_type")} for f in files],
             channel_id=channel,
             channels=channels,
             initial_comment=initial_comment,
@@ -4087,7 +4081,7 @@ def files_getUploadURLExternal(
     def files_completeUploadExternal(
         self,
         *,
-        files: List[Dict[str, str]],
+        files: List[Dict[str, Optional[str]]],
         channel_id: Optional[str] = None,
         channels: Optional[List[str]] = None,
         initial_comment: Optional[str] = None,