Skip to content

Commit 99113f0

Browse files
clavinRodneyU215
authored andcommitted
Return callback from RTMClient.run_on (#490)
* Return callback from `RTMClient.run_on` * Tidy up test * Change param name to snake_case Names are important πŸ˜„
1 parent aabf2d0 commit 99113f0

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

β€Žslack/rtm/client.pyβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ def run_on(*, event: str):
141141

142142
def decorator(callback):
143143
RTMClient.on(event=event, callback=callback)
144+
return callback
144145

145146
return decorator
146147

β€Žtests/rtm/test_rtm_client.pyβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,14 @@ def setUp(self):
1717
def tearDown(self):
1818
slack.RTMClient._callbacks = collections.defaultdict(list)
1919

20+
def test_run_on_returns_callback(self):
21+
@slack.RTMClient.run_on(event="message")
22+
def fn_used_elsewhere(**_unused_payload):
23+
pass
24+
25+
self.assertIsNotNone(fn_used_elsewhere)
26+
self.assertEqual(fn_used_elsewhere.__name__, "fn_used_elsewhere")
27+
2028
def test_run_on_annotation_sets_callbacks(self):
2129
@slack.RTMClient.run_on(event="message")
2230
def say_run_on(**payload):

0 commit comments

Comments
Β (0)