Skip to content

Commit c8dd10b

Browse files
committed
fix(web-client): update thread_ts arg to be required for chat_startStream method
1 parent 2ee91df commit c8dd10b

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

slack_sdk/web/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2878,7 +2878,7 @@ async def chat_startStream(
28782878
self,
28792879
*,
28802880
channel: str,
2881-
thread_ts: Optional[str] = None,
2881+
thread_ts: str,
28822882
markdown_text: Optional[str] = None,
28832883
recipient_team_id: Optional[str] = None,
28842884
recipient_user_id: Optional[str] = None,

slack_sdk/web/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2868,7 +2868,7 @@ def chat_startStream(
28682868
self,
28692869
*,
28702870
channel: str,
2871-
thread_ts: Optional[str] = None,
2871+
thread_ts: str,
28722872
markdown_text: Optional[str] = None,
28732873
recipient_team_id: Optional[str] = None,
28742874
recipient_user_id: Optional[str] = None,

slack_sdk/web/legacy_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2880,7 +2880,7 @@ def chat_startStream(
28802880
self,
28812881
*,
28822882
channel: str,
2883-
thread_ts: Optional[str] = None,
2883+
thread_ts: str,
28842884
markdown_text: Optional[str] = None,
28852885
recipient_team_id: Optional[str] = None,
28862886
recipient_user_id: Optional[str] = None,

tests/slack_sdk_async/web/test_web_client_coverage.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -568,10 +568,10 @@ async def run_method(self, method_name, method, async_method):
568568
self.api_methods_to_call.remove(method()["method"])
569569
await async_method()
570570
elif method_name == "chat_startStream":
571-
self.api_methods_to_call.remove(method(channel="C123")["method"])
572-
method(channel="C123", recipient_team_id="T123", recipient_user_id="U123")
573-
await async_method(channel="C123")
574-
await async_method(channel="C123", recipient_team_id="T123", recipient_user_id="U123")
571+
self.api_methods_to_call.remove(method(channel="C123", thread_ts="123.123")["method"])
572+
await async_method(channel="C123", thread_ts="123.123")
573+
method(channel="C123", thread_ts="123.123", recipient_team_id="T123", recipient_user_id="U123")
574+
await async_method(channel="C123", thread_ts="123.123", recipient_team_id="T123", recipient_user_id="U123")
575575
elif method_name == "chat_stopStream":
576576
self.api_methods_to_call.remove(
577577
method(channel="C123", ts="123.123", blocks=[{"type": "markdown", "text": "**twelve**"}])["method"]

0 commit comments

Comments
 (0)