Add tests and move them to new files

Author: WilliamBergamin

tests/slack_sdk/web/test_web_client_issue_921_custom_logger.py

@@ -23,23 +23,6 @@ def test_if_it_uses_custom_logger(self):
         client.chat_postMessage(channel="C111", text="hello")
         self.assertTrue(logger.called)
 
-    def test_if_property_returns_custom_logger(self):
-        logger = CustomLogger("test-logger")
-        client = WebClient(
-            base_url="http://localhost:8888",
-            token="xoxb-api_test",
-            logger=logger,
-        )
-        self.assertEqual(client.logger, logger)
-
-    def test_logger_property_has_no_setter(self):
-        client = WebClient(
-            base_url="http://localhost:8888",
-            token="xoxb-api_test",
-        )
-        with self.assertRaises(AttributeError):
-            client.logger = CustomLogger("test-logger")
-
 
 class CustomLogger(Logger):
     called: bool

tests/slack_sdk/web/test_web_client_logger.py

@@ -0,0 +1,38 @@
+import logging
+import unittest
+
+from slack_sdk import WebClient
+from slack_sdk.web import base_client
+from tests.slack_sdk.web.mock_web_api_handler import MockHandler
+from tests.mock_web_api_server import setup_mock_web_api_server, cleanup_mock_web_api_server
+
+
+class TestWebClientLogger(unittest.TestCase):
+    test_logger: logging.Logger
+
+    def setUp(self):
+        self.test_logger = logging.Logger("test-logger")
+        setup_mock_web_api_server(self, MockHandler)
+
+    def tearDown(self):
+        cleanup_mock_web_api_server(self)
+
+    def test_logger_property_returns_default_logger(self):
+        client = WebClient(base_url="http://localhost:8888", token="xoxb-api_test")
+        self.assertEqual(client.logger.name, base_client.__name__)
+
+    def test_logger_property_returns_custom_logger(self):
+        client = WebClient(
+            base_url="http://localhost:8888",
+            token="xoxb-api_test",
+            logger=self.test_logger,
+        )
+        self.assertEqual(client.logger, self.test_logger)
+
+    def test_logger_property_has_no_setter(self):
+        client = WebClient(
+            base_url="http://localhost:8888",
+            token="xoxb-api_test",
+        )
+        with self.assertRaises(AttributeError):
+            client.logger = self.test_logger

tests/slack_sdk_async/web/test_async_web_client_logger.py

@@ -0,0 +1,38 @@
+import logging
+import unittest
+
+from slack_sdk.web.async_client import AsyncWebClient
+from slack_sdk.web import async_base_client
+from tests.slack_sdk.web.mock_web_api_handler import MockHandler
+from tests.mock_web_api_server import setup_mock_web_api_server_async, cleanup_mock_web_api_server_async
+
+
+class TestAsyncWebClientLogger(unittest.TestCase):
+    test_logger: logging.Logger
+
+    def setUp(self):
+        self.test_logger = logging.Logger("test-logger")
+        setup_mock_web_api_server_async(self, MockHandler)
+
+    def tearDown(self):
+        cleanup_mock_web_api_server_async(self)
+
+    def test_logger_property_returns_default_logger(self):
+        client = AsyncWebClient(base_url="http://localhost:8888", token="xoxb-api_test")
+        self.assertEqual(client.logger.name, async_base_client.__name__)
+
+    def test_logger_property_returns_custom_logger(self):
+        client = AsyncWebClient(
+            base_url="http://localhost:8888",
+            token="xoxb-api_test",
+            logger=self.test_logger,
+        )
+        self.assertEqual(client.logger, self.test_logger)
+
+    def test_logger_property_has_no_setter(self):
+        client = AsyncWebClient(
+            base_url="http://localhost:8888",
+            token="xoxb-api_test",
+        )
+        with self.assertRaises(AttributeError):
+            client.logger = self.test_logger

tests/slack_sdk_async/web/test_web_client_issue_921_custom_logger.py

@@ -25,23 +25,6 @@ async def test_if_it_uses_custom_logger(self):
         await client.chat_postMessage(channel="C111", text="hello")
         self.assertTrue(logger.called)
 
-    def test_if_property_returns_custom_logger(self):
-        logger = CustomLogger("test-logger")
-        client = AsyncWebClient(
-            base_url="http://localhost:8888",
-            token="xoxb-api_test",
-            logger=logger,
-        )
-        self.assertEqual(client.logger, logger)
-
-    def test_logger_property_has_no_setter(self):
-        client = AsyncWebClient(
-            base_url="http://localhost:8888",
-            token="xoxb-api_test",
-        )
-        with self.assertRaises(AttributeError):
-            client.logger = CustomLogger("test-logger")
-
 
 class CustomLogger(Logger):
     called: bool