Skip to content

docs: removing external links for unified nav#1895

Open
haleychaas wants to merge 1 commit into
mainfrom
unified-nav
Open

docs: removing external links for unified nav#1895
haleychaas wants to merge 1 commit into
mainfrom
unified-nav

Conversation

@haleychaas

Copy link
Copy Markdown

Summary

I'm working on uniting the nav bar for all of the tools so that you don't lose the context of the rest of the nav when you click on one of the tools. In this PR, I'm removing the external links (release notes, github repo, contributor's guide) to cut down on bloat in the nav menu when they are all united. Since the github repo and contributor's guide are already mentioned in the landing page, I just added the release notes link to that.

Preview for one nav here: https://docs-slack-d-unified-na-idfrpr.herokuapp.com/tools
PR for unified nav here: https://github.com/slackapi/docs/pull/605

Testing

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@haleychaas haleychaas requested a review from a team as a code owner June 11, 2026 20:52
@haleychaas haleychaas requested review from a team and removed request for a team June 11, 2026 20:55
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.13%. Comparing base (0b4f57b) to head (2711dee).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
- Coverage   84.14%   84.13%   -0.01%     
==========================================
  Files         117      117              
  Lines       13356    13356              
==========================================
- Hits        11238    11237       -1     
- Misses       2118     2119       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haleychaas LGTM! Same ordering suggestion as the Bolt for Python PR - is moving "Release notes" before "Contributing" alright for a first read?

  • Getting help
  • Release notes
  • Contributing

Feel free to merge whenever best! 📰

@zimeg zimeg added the docs M-T: Documentation work only label Jun 11, 2026
@zimeg zimeg added this to the 3.43.0 milestone Jun 11, 2026
@zimeg zimeg changed the title Docs: Removing external links for unified nav Docs: removing external links for unified nav Jun 11, 2026
@zimeg zimeg changed the title Docs: removing external links for unified nav docs: removing external links for unified nav Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants